Date: Fri, 09 Feb 2007 13:38:17 -0600 From: "Jeremy Messenger" <mezz7@cox.net> To: "Luigi Rizzo" <rizzo@icir.org> Cc: mi@aldan.algebra.com, multimedia@freebsd.org Subject: Re: vic patches for video4linux support Message-ID: <op.tnhx53e19aq2h7@mezz.mezzweb.com> In-Reply-To: <20070209105414.A1702@xorpc.icir.org> References: <20070209073353.A99372@xorpc.icir.org> <op.tnhvnsg49aq2h7@mezz.mezzweb.com> <20070209105414.A1702@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 09 Feb 2007 12:54:14 -0600, Luigi Rizzo <rizzo@icir.org> wrote:
> On Fri, Feb 09, 2007 at 12:44:06PM -0600, Jeremy Messenger wrote:
>> On Fri, 09 Feb 2007 09:33:53 -0600, Luigi Rizzo <rizzo@icir.org> wrot=
e:
> ...
>> > + fix configure to look for videodev.h in the place where it is on
>> > FreeBSD, and disable v4l2 support for the time being as there
>> > is none as far as i know;
>>
>> Disapprove because of hardcore. You should be replace from =
>> patch-configure
>> to REINPLACE_CMD with ${LOCALBASE}. Something like this (untest):
>
> Thanks for looking at it.
>
> will look at how to improve the patch, however what you suggest is
> not enough in this case:
Yes, it is in my second suggest.
> there are [at least] two instances of the match
> pattern, one of which i want to replace, the other i do not.
You have strip out my other suggest about %%LOCALBASE%%, which it's what=
=
you want. Example:
patch-configure:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
%%LOCALBASE%%/include/linux
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
Makefile:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
[...]
@${REINPLACE_CMD} -e 's|%%LOCALBASE%%|${LOCALBASE}|g' \
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> (also consider that the source is basically dead - nobody
> is going to change it so there is little point in being
> flexible on the input).
>
> ...
>> > + add -I/usr/local/include in the search path, for the above file;
>>
>> Why? The CONFIGURE_ENV doesn't work?
>
> will try it, thanks
If the one that we already have CONFIGURE_ENV doesn't work, then I am ok=
=
with patch. Have you test it without patch?
Cheers,
Mezz
> cheers
> luigi
-- =
mezz7@cox.net - mezz@FreeBSD.org
FreeBSD GNOME Team - FreeBSD Multimedia Hat (ports, not src)
http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
http://wiki.freebsd.org/multimedia - multimedia@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.tnhx53e19aq2h7>