Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Nov 2018 10:35:44 -0800
From:      Conrad Meyer <cem@freebsd.org>
To:        arybchik@freebsd.org
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r341327 - head/sys/dev/sfxge
Message-ID:  <CAG6CVpWRrGox-sMhWbc6==EPoWoJwzHCnC0xfRbvSwYjhSwXyA@mail.gmail.com>
In-Reply-To: <7545b110-4930-d49f-f99f-7ec17db7e7a7@oktetlabs.ru>
References:  <201811300711.wAU7B5R6084752@repo.freebsd.org> <d60f54ae-a1a6-bad5-73f0-c898d0579089@FreeBSD.org> <7545b110-4930-d49f-f99f-7ec17db7e7a7@oktetlabs.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 30, 2018 at 10:16 AM Andrew Rybchenko <arybchik@freebsd.org> wr=
ote:
> Basically I'm ready to follow any sensible policy.

Hi Andrew,

I think general policy is to not include a "Differential Revision:"
line in a commit message unless there was actual review there.

(That's separate from the issue of creating a bunch of reviews that no
one will ever look at =E2=80=94 which is a different kind of spam.)

> Yes in this particular case these 2 hundreds of patches is the result of =
2 years of development.

Why are they being committed now, hundreds at a time, instead of as
they were developed over the last two years?

Thanks,
Conrad



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpWRrGox-sMhWbc6==EPoWoJwzHCnC0xfRbvSwYjhSwXyA>