Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Jul 2014 16:28:13 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r268493 - head/lib/libfetch
Message-ID:  <20140710132813.GQ93733@kib.kiev.ua>
In-Reply-To: <201407101304.s6AD4rne079137@svn.freebsd.org>
References:  <201407101304.s6AD4rne079137@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--3WNG/pnnEPQXt+KF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 10, 2014 at 01:04:53PM +0000, Baptiste Daroussin wrote:
> Author: bapt
> Date: Thu Jul 10 13:04:52 2014
> New Revision: 268493
> URL: http://svnweb.freebsd.org/changeset/base/268493
>=20
> Log:
>   Support EAGAIN in fetch_writev
>  =20
>   Reviewed by:	des
>   Approved by:	des
>=20
> Modified:
>   head/lib/libfetch/common.c
>=20
> Modified: head/lib/libfetch/common.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/lib/libfetch/common.c	Thu Jul 10 12:41:58 2014	(r268492)
> +++ head/lib/libfetch/common.c	Thu Jul 10 13:04:52 2014	(r268493)
> @@ -1110,6 +1110,8 @@ fetch_writev(conn_t *conn, struct iovec=20
>  			errno =3D 0;
>  			pfd.revents =3D 0;
>  			if (poll(&pfd, 1, deltams) < 0) {
> +				if (errno =3D=3D EAGAIN)
> +					continue;
>  				if (errno =3D=3D EINTR && fetchRestartCalls)
>  					continue;
>  				return (-1);

How is this error possible ? poll(2) converts EAGAIN from seltdwait(9)
to no error.

--3WNG/pnnEPQXt+KF
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJTvpTsAAoJEJDCuSvBvK1BOhEP/1QQls2vv02DQTvOgl/eKkON
EySdCYrMqQJ3HtyBNAoMZU2E0vuy3YdSVq8Y+n/fiZ2vc5cqQj9pLVJgWT4pz/ub
WtWoxJBRqKgw5XTORVndgmE/2MAIi9jS2nt1Hn2P1IqT39YrHYYMPhMoKlu2Lofo
rs7jr7qHMfnY4FszTL6vqIDfSLipKv8nBybgoAEYylG2oFTHlSR8g34LBArOf3pZ
iZq93CLH5gkFaQngTDEE1XVE2T9sRshxNPUoJxtcTuqo80RIKD3eq2pew9EYnQh6
vKFUteNy13ZdS03ruzzLo+NuxSKPxyCn83CVF4Noarj0z/Fq5c91JYBbB0V32Q1n
vLw2kiqKKZrJwQPuoXUcCRvtezVuzqTvMhTL8ZoLR8PnvJlzmneV/i04ax0pCNJN
bd6Y7JGIFK2BpS53WkkSrVNcMH0oC7vlxDtuO66DObDtw3JEWTV6rXGsgoaGWnYr
AGxH49ESh5Yy9JXL9Z1aIG4bd/icXTE9X1+Sl76p8iiUrr3ZqCPMm3//dm16Iu2y
aBlV0AqkVy8f/LILrrYGOvWZF7Twyj0sKZkVYCIY728YPI5V4pF7AWgya1/KmKCt
FoDkzAB+eD7S1PTq5+O4HiIvXwSc9J/3DqaTbBKTV+/+AkeF3ILX7wxE7i47HGhQ
kisrVFJxqIHvANV0KQua
=hbef
-----END PGP SIGNATURE-----

--3WNG/pnnEPQXt+KF--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140710132813.GQ93733>