Date: Mon, 04 Feb 2002 16:16:02 +0000 From: Mark Murray <mark@grondar.za> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys socket.h types.h Message-ID: <200202041616.g14GG7E56111@greenpeace.grondar.org> In-Reply-To: <20020205002930.K22843-100000@gamplex.bde.org> ; from Bruce Evans <bde@zeta.org.au> "Tue, 05 Feb 2002 00:44:22 %2B1100." References: <20020205002930.K22843-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > So how does one write a (decent) macro to return a correct value > > for min(1u, -1)? > > One doesn't. One can write fairly indecent ones using Gnu C, but > FreeBSD currently uses min functions instead of the MIN macro in the > kernel. > > > howmany() is used so much in the kernel, and is defined in multiple > > places, so methinks it needs to be a function (inline?). It kicks > > out zillions of wanings when you try to lint it. > > The warnings are probably correct. They probably indicate that callers > are passing mismatched arg types. Your thoughts on turning howmany() into a function? > Perhaps more seriously, the change to the type of NBBY exposes an old > bug in ffs and causes kernel panics. See another thread. Please > back it out too, and consider doing the same for all the other type > changes. If that is a bug, then surely that is what needs fixing? M -- o Mark Murray \_ FreeBSD Services Limited O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202041616.g14GG7E56111>