Date: Sun, 6 Jun 2021 17:37:20 +0000 From: Dmitry Chagin <dchagin@freebsd.org> To: Lutz Donnerhacke <lutz@donnerhacke.de> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0f8dab45404f - main - linux(4): Fix timeout parameter of rt_sigtimedwait syscall, which is timespec not a timeval. Message-ID: <YL0H0CpROpvBo6oA@heemeyer.club> In-Reply-To: <20210606163708.GA10633@belenus.iks-jena.de> References: <202106061440.156EeLEK068536@gitrepo.freebsd.org> <20210606163708.GA10633@belenus.iks-jena.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 06, 2021 at 06:37:08PM +0200, Lutz Donnerhacke wrote: > On Sun, Jun 06, 2021 at 02:40:21PM +0000, Dmitry Chagin wrote: > > The branch main has been updated by dchagin: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=0f8dab45404f347752470579feccc6d2739b9570 > > > > commit 0f8dab45404f347752470579feccc6d2739b9570 > > Author: Dmitry Chagin <dchagin@FreeBSD.org> > > AuthorDate: 2021-06-07 02:35:35 +0000 > > Commit: Dmitry Chagin <dchagin@FreeBSD.org> > > CommitDate: 2021-06-07 02:35:35 +0000 > > > > linux(4): Fix timeout parameter of rt_sigtimedwait syscall, which is > > timespec not a timeval. > > > > MFC after: 2 weeks > > May I ask, why NONE of those commits are discussed beforehand in Phabricator? > freebsd/main is not intended to be used as a local development train by > anybody who wants to play with a specific submodule. > in the main, these are trivial changes, there too few reviewrs in the Linuxulator area to spend their time. feel free to review, there are many requests. > I don't want to see any of those "try and fix" commits to be MFCed into any > stable without serious squashing and fixup runs, in order to minimize the > impact on the stable trains. If there is a known bug in the commit, the > MFCed commit must contain all the known necessary fixes to avoid any > breakage of the stable train. > > So please do not mess up the freebsd/main any further. Thank you. please, re-read the committer's guide carefully, especially about committers relations and pre-commit review.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YL0H0CpROpvBo6oA>