Date: Mon, 9 Mar 2026 16:38:24 +0000 From: Andrew Turner <andrew@FreeBSD.org> To: "Herbert J. Skuhra" <herbert@gojira.at> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>, Sarah Walker <sarah.walker2@arm.com> Subject: Re: git: c499ad6f997c - main - virtio: Use bus_dma for ring and indirect buffer allocations Message-ID: <A4F278F1-2990-410D-84C5-E250A6E9E265@FreeBSD.org> In-Reply-To: <87ecludxuh.wl-herbert@gojira.at> References: <69a71c75.40215.43f39fc6@gitrepo.freebsd.org> <87ecludxuh.wl-herbert@gojira.at>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On 8 Mar 2026, at 17:39, Herbert J. Skuhra <herbert@gojira.at> wrote: > > On Tue, 03 Mar 2026 18:37:57 +0100, Andrew Turner wrote: >> >> The branch main has been updated by andrew: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=c499ad6f997c8c5f61c88925e6d1e826d0c0f6c4 >> >> commit c499ad6f997c8c5f61c88925e6d1e826d0c0f6c4 >> Author: Sarah Walker <sarah.walker2@arm.com> >> AuthorDate: 2026-03-03 16:08:11 +0000 >> Commit: Andrew Turner <andrew@FreeBSD.org> >> CommitDate: 2026-03-03 16:29:15 +0000 >> >> virtio: Use bus_dma for ring and indirect buffer allocations >> >> While the majority of virtio platforms will be fully coherent, some may >> require cache maintenance or other specific device memory handling (eg for >> secure partitioning). Using bus_dma allows for these usecases. >> >> The virtio buffers are marked as coherent; this should ensure that sync >> calls are no-ops in the common cases. >> >> Reviewed by: andrew >> Sponsored by: Arm Ltd >> Differential Revision: https://reviews.freebsd.org/D54959 >> --- >> sys/dev/virtio/virtio_ring.h | 27 ++++-- >> sys/dev/virtio/virtqueue.c | 216 +++++++++++++++++++++++++++++++++++++------ >> 2 files changed, 209 insertions(+), 34 deletions(-) > > After this change I see a lot of "kernel: vtnet0: watchdog timeout on > queue xx" errors on amd64 (arm64 seems to be OK). > > Reverting this commit resolves the issue. Can you try the change in https://reviews.freebsd.org/D55766? It re-adds memory barriers for amd64. Andrew [-- Attachment #2 --] <html><head><meta http-equiv="content-type" content="text/html; charset=us-ascii"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><br><div><blockquote type="cite"><div>On 8 Mar 2026, at 17:39, Herbert J. Skuhra <herbert@gojira.at> wrote:</div><br class="Apple-interchange-newline"><div><meta charset="UTF-8"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">On Tue, 03 Mar 2026 18:37:57 +0100, Andrew Turner wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br>The branch main has been updated by andrew:<br><br>URL: https://cgit.FreeBSD.org/src/commit/?id=c499ad6f997c8c5f61c88925e6d1e826d0c0f6c4<br><br>commit c499ad6f997c8c5f61c88925e6d1e826d0c0f6c4<br>Author: Sarah Walker <sarah.walker2@arm.com><br>AuthorDate: 2026-03-03 16:08:11 +0000<br>Commit: Andrew Turner <andrew@FreeBSD.org><br>CommitDate: 2026-03-03 16:29:15 +0000<br><br> virtio: Use bus_dma for ring and indirect buffer allocations<br><br> While the majority of virtio platforms will be fully coherent, some may<br> require cache maintenance or other specific device memory handling (eg for<br> secure partitioning). Using bus_dma allows for these usecases.<br><br> The virtio buffers are marked as coherent; this should ensure that sync<br> calls are no-ops in the common cases.<br><br> Reviewed by: andrew<br> Sponsored by: Arm Ltd<br> Differential Revision: https://reviews.freebsd.org/D54959<br>---<br>sys/dev/virtio/virtio_ring.h | 27 ++++--<br>sys/dev/virtio/virtqueue.c | 216 +++++++++++++++++++++++++++++++++++++------<br>2 files changed, 209 insertions(+), 34 deletions(-)<br></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">After this change I see a lot of "kernel: vtnet0: watchdog timeout on</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">queue xx" errors on amd64 (arm64 seems to be OK).</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">Reverting this commit resolves the issue.</span></div></blockquote><br></div><div>Can you try the change in <a href="https://reviews.freebsd.org/D55766?">https://reviews.freebsd.org/D55766?</a> It re-adds memory barriers for amd64.</div><div><br></div><div>Andrew</div><br></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A4F278F1-2990-410D-84C5-E250A6E9E265>