Date: Mon, 7 Oct 1996 19:42:23 +0200 (MET DST) From: J Wunsch <j@uriah.heep.sax.de> To: wosch@cs.tu-berlin.de (Wolfram Schneider) Cc: joerg@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.bin/su su.c Message-ID: <199610071742.TAA14992@uriah.heep.sax.de> In-Reply-To: <199610071118.NAA11594@caramba.cs.tu-berlin.de> from Wolfram Schneider at "Oct 7, 96 01:18:44 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
As Wolfram Schneider wrote:
> > Export $TERM only if it has been set in our environment.
>
> BTW, setenv(3) should not core if the second argument is a NULL
> pointer. It should print a warning ("silly programmer error, cannot
> set variable XYZ in function setenv(3)") and return.
A coredump is a perfectly valid complaint at a stupid programmer. We
already decided to prefer this method over wasting time at other
occurences, e.g. by not allowing ``strcmp(foobar, NULL)'' etc. I
don't see where the setenv() case is different.
--
cheers, J"org
joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199610071742.TAA14992>