Date: Fri, 15 Feb 2019 20:55:26 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Warner Losh <imp@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344191 - head/sbin/nvmecontrol Message-ID: <EBC9A98F-5E80-458F-927E-38948C0BC913@gmail.com> In-Reply-To: <201902160015.x1G0F3EJ060777@repo.freebsd.org> References: <201902160015.x1G0F3EJ060777@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 15, 2019, at 16:15, Warner Losh <imp@freebsd.org> wrote: >=20 > Author: imp > Date: Sat Feb 16 00:15:02 2019 > New Revision: 344191 > URL: https://svnweb.freebsd.org/changeset/base/344191 >=20 > Log: > Remove write-only s_flag. >=20 > Modified: > head/sbin/nvmecontrol/firmware.c >=20 > Modified: head/sbin/nvmecontrol/firmware.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sbin/nvmecontrol/firmware.c Fri Feb 15 23:46:34 2019 (r3441= 90) > +++ head/sbin/nvmecontrol/firmware.c Sat Feb 16 00:15:02 2019 (r3441= 91) > @@ -177,7 +177,7 @@ static void > firmware(const struct nvme_function *nf, int argc, char *argv[]) > { > int fd =3D -1, slot =3D 0; > - int a_flag, s_flag, f_flag; > + int a_flag, f_flag; > int activate_action, reboot_required; > int opt; > char *p, *image =3D NULL; > @@ -188,7 +188,7 @@ firmware(const struct nvme_function *nf, int argc, cha= > uint8_t fw_slot1_ro, fw_num_slots; > struct nvme_controller_data cdata; >=20 > - a_flag =3D s_flag =3D f_flag =3D false; > + a_flag =3D f_flag =3D false; >=20 > while ((opt =3D getopt(argc, argv, "af:s:")) !=3D -1) { Hi Warner! Should =E2=80=9Cs:=E2=80=9D be removed here, along with any correspondin= g documentation about =E2=80=98-s foo=E2=80=99? Thanks so much! -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EBC9A98F-5E80-458F-927E-38948C0BC913>