Date: Fri, 15 Feb 2019 20:55:26 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Warner Losh <imp@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344191 - head/sbin/nvmecontrol Message-ID: <EBC9A98F-5E80-458F-927E-38948C0BC913@gmail.com> In-Reply-To: <201902160015.x1G0F3EJ060777@repo.freebsd.org> References: <201902160015.x1G0F3EJ060777@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 15, 2019, at 16:15, Warner Losh <imp@freebsd.org> wrote: > > Author: imp > Date: Sat Feb 16 00:15:02 2019 > New Revision: 344191 > URL: https://svnweb.freebsd.org/changeset/base/344191 > > Log: > Remove write-only s_flag. > > Modified: > head/sbin/nvmecontrol/firmware.c > > Modified: head/sbin/nvmecontrol/firmware.c > ============================================================================== > --- head/sbin/nvmecontrol/firmware.c Fri Feb 15 23:46:34 2019 (r344190) > +++ head/sbin/nvmecontrol/firmware.c Sat Feb 16 00:15:02 2019 (r344191) > @@ -177,7 +177,7 @@ static void > firmware(const struct nvme_function *nf, int argc, char *argv[]) > { > int fd = -1, slot = 0; > - int a_flag, s_flag, f_flag; > + int a_flag, f_flag; > int activate_action, reboot_required; > int opt; > char *p, *image = NULL; > @@ -188,7 +188,7 @@ firmware(const struct nvme_function *nf, int argc, cha > uint8_t fw_slot1_ro, fw_num_slots; > struct nvme_controller_data cdata; > > - a_flag = s_flag = f_flag = false; > + a_flag = f_flag = false; > > while ((opt = getopt(argc, argv, "af:s:")) != -1) { Hi Warner! Should “s:” be removed here, along with any corresponding documentation about ‘-s foo’? Thanks so much! -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EBC9A98F-5E80-458F-927E-38948C0BC913>