Date: Mon, 24 Sep 2001 11:24:38 -0400 (EDT) From: Robert Watson <rwatson@freebsd.org> To: "Matthew N. Dodd" <winter@jurai.net> Cc: freebsd-net@freebsd.org Subject: Re: review request. Message-ID: <Pine.NEB.3.96L.1010924112206.66358B-100000@fledge.watson.org> In-Reply-To: <Pine.BSF.4.21.0109230534170.3806-200000@sasami.jurai.net>
next in thread | previous in thread | raw e-mail | index | archive | help
I'd be happy to see a KASSERT() dropped in there--the type of bug this is probably intended to address is a reversed set of procedures during interface cleanup, or multiple invocation. In SMPng, the failure modes for this kind of error situation will be a lot less forgiving (especially with regards to potential races), and as such we want to find those failures early, rather than let them slip through. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services On Sun, 23 Sep 2001, Matthew N. Dodd wrote: > sys/net/if.c and bpf.c have problems with if_detach() and > bpfdetach() when they are called with a struct ifnet that has not had > if_attach() and bpfattach() called on it. Null pointer reference -> > *boom* etc. > > This patch fixes the test already present in bpfdetach() and adds a test > to if_detach(). > > Thanks. > > -- > | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | > | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | > | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever | > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1010924112206.66358B-100000>