Date: Fri, 20 Aug 2004 15:15:25 -0400 (EDT) From: Robert Watson <rwatson@freebsd.org> To: Gordon Bergling <gbergling@0xfce3.net> Cc: freebsd-current@freebsd.org Subject: Re: [5.3-ALPHA] Panic in in6_pcb.c Message-ID: <Pine.NEB.3.96L.1040820151423.46149A-100000@fledge.watson.org> In-Reply-To: <20040820183544.GA986@nemesis.md.0xfce3.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 20 Aug 2004, Gordon Bergling wrote:
> I recently got a panic with the following output:
>
> | panic: lock (sleep mutex) inp not locked @
> | /usr/src/sys/netinet6/in6_pcb.c:710
>
> System is a fresh 5.3-ALPHA running on an idle workstation. Just a few
> console applications were running in the background.
>
> I haven't get my hands on a coredump yet, but if someone is interested
> in it I could provide further information.
Is this something you can reproduce? The attached patch was created when
Jun Kuriyama ran into the same panic a few days ago, but he wasn't sure if
he could reproduce it. If you could test it and let me know, that would
be great, thanks!
Robert N M Watson FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org Principal Research Scientist, McAfee Research
Index: in6_pcb.c
===================================================================
RCS file: /home/ncvs/src/sys/netinet6/in6_pcb.c,v
retrieving revision 1.59
diff -u -r1.59 in6_pcb.c
--- in6_pcb.c 14 Aug 2004 15:32:20 -0000 1.59
+++ in6_pcb.c 18 Aug 2004 04:02:00 -0000
@@ -705,9 +705,11 @@
}
do_notify:
- if (notify)
- (*notify)(inp, errno);
- INP_UNLOCK(inp);
+ if (notify) {
+ if ((*notify)(inp, errno))
+ INP_UNLOCK(inp);
+ } else
+ INP_UNLOCK(inp);
}
INP_INFO_WUNLOCK(pcbinfo);
splx(s);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1040820151423.46149A-100000>