Date: Wed, 27 Nov 2019 20:16:37 -0800 From: Ryan Libby <rlibby@freebsd.org> To: Michael Butler <imb@protected-networks.net> Cc: freebsd-current <freebsd-current@freebsd.org>, jeff@freebsd.org Subject: Re: SVN r355148/9 breaks build Message-ID: <CAHgpiFx60dJ=JmqyrYT7XgeUbkawivBgYTh3mUq-CieTgigTMA@mail.gmail.com> In-Reply-To: <CAHgpiFwn27AVfwCWS6Yyzmqb6ZfbsR0i5A2D=m9AKyf897JJVA@mail.gmail.com> References: <3e4daebb-cd5d-a9b3-daa1-d335f18e9ec8@protected-networks.net> <CAHgpiFwn27AVfwCWS6Yyzmqb6ZfbsR0i5A2D=m9AKyf897JJVA@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Wed, Nov 27, 2019 at 7:23 PM Ryan Libby <rlibby@freebsd.org> wrote: > > On Wed, Nov 27, 2019 at 6:44 PM Michael Butler > <imb@protected-networks.net> wrote: > > > > Something missing from a header here? > > > > Building /usr/obj/usr/src/amd64.amd64/sys/VM01/uma_core.o > > --- uma_core.o --- > > /usr/src/sys/vm/uma_core.c:1864:39: error: use of undeclared identifier > > 'sysctl___vm_uma' > > zone->uz_oid = SYSCTL_ADD_NODE(NULL, > > SYSCTL_STATIC_CHILDREN(_vm_uma), > > ^ > > /usr/src/sys/sys/sysctl.h:245:44: note: expanded from macro > > 'SYSCTL_STATIC_CHILDREN' > > #define SYSCTL_STATIC_CHILDREN(oid_name) > > (&sysctl__##oid_name.oid_children) > > ^ > > <scratch space>:154:1: note: expanded from here > > sysctl___vm_uma > > ^ > > /usr/src/sys/vm/uma_core.c:1864:15: error: assigning to 'struct > > sysctl_oid *' from incompatible type 'void' > > zone->uz_oid = SYSCTL_ADD_NODE(NULL, > > SYSCTL_STATIC_CHILDREN(_vm_uma), > > ^ > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 2 errors generated. > > *** [uma_core.o] Error code 1 > > > > imb > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > Ah, SYSCTL_NODE(_vm, OID_AUTO, uma, ...) is accidentally under > INVARIANTS and needs to move out. > > I'll patch this up in an hour if jeff or someone else doesn't beat me to it. Should be fixed in r355166. Thanks for the report.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHgpiFx60dJ=JmqyrYT7XgeUbkawivBgYTh3mUq-CieTgigTMA>