Date: Fri, 5 Mar 2021 13:26:36 -0500 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Gordon Bergling <gbe@freebsd.org> Cc: Mark Johnston <markj@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 89b650872bba - main - ktls: Hide initialization message behind bootverbose Message-ID: <20210305182636.y6gi3injvqvd2yu4@mutt-hbsd> In-Reply-To: <YEJ3PDT3oOX09z%2BY@lion.0xfce3.net> References: <202103051815.125IFDNK001016@gitrepo.freebsd.org> <YEJ3PDT3oOX09z%2BY@lion.0xfce3.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] I wonder if it'd be worth it to report such data via sysctl. Thoughts? -- Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc On Fri, Mar 05, 2021 at 07:23:56PM +0100, Gordon Bergling wrote: > Hi Mark, > > is this change not a little bit to aggressive in terms of dmesg cleanup? > > There are a lot messages about what subsystem is initialized with > how many threads, like for example TCP HTPS and TCP BBR. > > Hiding this information could be suboptimal for some users. > > --Gordon > > On Fri, Mar 05, 2021 at 06:15:13PM +0000, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=89b650872bba2e4bfbc94a200946b461ef69ae22 > > > > commit 89b650872bba2e4bfbc94a200946b461ef69ae22 > > Author: Mark Johnston <markj@FreeBSD.org> > > AuthorDate: 2021-03-05 18:11:02 +0000 > > Commit: Mark Johnston <markj@FreeBSD.org> > > CommitDate: 2021-03-05 18:11:02 +0000 > > > > ktls: Hide initialization message behind bootverbose > > > > We don't typically print anything when a subsystem initializes itself, > > and KTLS is currently disabled by default anyway. > > > > Reviewed by: jhb > > MFC after: 1 week > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D29097 > > --- > > sys/kern/uipc_ktls.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/sys/kern/uipc_ktls.c b/sys/kern/uipc_ktls.c > > index 5125061e0879..1fd1eca39b59 100644 > > --- a/sys/kern/uipc_ktls.c > > +++ b/sys/kern/uipc_ktls.c > > @@ -495,7 +495,8 @@ ktls_init(void *dummy __unused) > > } > > } > > > > - printf("KTLS: Initialized %d threads\n", ktls_number_threads); > > + if (bootverbose) > > + printf("KTLS: Initialized %d threads\n", ktls_number_threads); > > } > > SYSINIT(ktls, SI_SUB_SMP + 1, SI_ORDER_ANY, ktls_init, NULL); > > > > _______________________________________________ > > dev-commits-src-main@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > > To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@freebsd.org" > > -- > _______________________________________________ > dev-commits-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all > To unsubscribe, send any mail to "dev-commits-src-all-unsubscribe@freebsd.org" [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmBCd9oACgkQ/y5nonf4 4foCQA//TMnPacsJYnVvGpuO9qQXO/WSYvaTkREdKHzrIK4LV6XAG79dCPlob5xU A+h19EgFGMRkSniQgo6uaFg58T3H+1chiI9+flVgAJyLA+iykvEHdNQQjQ3o7455 v4m/g1uAA1B9ELeM3CyC8gUoDroQzYJQPq7ZU0AtnS4iRlUMEOH9Nv9xhqAntTaG 4JmPaw/MTwvSxzJIahQMCFNw+n1xFezH8BytobVmxdoSV2ikOf0/SPj/e64SFpG1 PIS/4MtIkZr3fAPMWKCenK628K/ckP1bM/1CsOu3x9p2UgDq3r7L7ey3TXda47qE 2NW8fxocoiyDdL0erA+V8lbSIaHiEy4jlSApg3kIUiGkvpyQWeBt7plI2BOMjdHH tZIfvsYsxFV15a0O/19jiuUJao63hNThPRrV47ujikuxw8FsE4UIMqdeqqZTEOmL 1K7dH+mBYe6jWHpBtiZBfAb4T0upFUd+Oqn4MOtzrzi71yx88oY23N0zGPyc/rIa KBC8PHwg4usqo4Duhyi/hAYBrGXbMmRPZaB1eFUIMUvazpe7MWPg356DqrZipAv0 1AJhWEvU75JF5+tQH378KWrcIHbkoTrUY7Vo8/qXpJaLI4XnqSGFWU+GbgKOzizk BpO/WWiwMV//W00zu3zxGcit8dQENr9XT0f0LIFTtpVrt+eWj/g= =hI/6 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210305182636.y6gi3injvqvd2yu4>