Date: Mon, 9 Nov 2015 18:06:06 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Garrett Cooper <yaneurabeya@gmail.com>, Bryan Drewery <bdrewery@FreeBSD.org> Cc: =?UTF-8?B?Sm9zw6kgUMOpcmV6?= <fbl@aoek.com>, freebsd-current@freebsd.org Subject: Re: Failing buildword due to execution permission (with fix) Message-ID: <5641510E.4020602@FreeBSD.org> In-Reply-To: <45AD4F5D-DABD-47ED-99FA-A40FFFF3CC7E@gmail.com> References: <d2efef40a9e28bec03742c49ec5e4682@mail.yourbox.net> <233C431B-1675-4A55-A46E-B1B858056A09@gmail.com> <564136A0.4080406@FreeBSD.org> <5655EBD2-5EC5-425E-82B9-F7FF30312F02@gmail.com> <564147FF.2050107@FreeBSD.org> <45AD4F5D-DABD-47ED-99FA-A40FFFF3CC7E@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 11/9/2015 6:01 PM, Garrett Cooper wrote:
>
>> On Nov 9, 2015, at 17:27, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>>
>>> On 11/9/2015 5:17 PM, Garrett Cooper wrote:
>>>
>>>> On Nov 9, 2015, at 16:13, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>>>
>>>
>>> ...
>>>
>>>> If this is a shell file then it is best to invoke it with 'sh' rather
>>>> than a chmod/#!. The src checkout should be noexec-safe.
>>>
>>> Right. I think it'd be a good idea for me to hunt down other issues though in the build by setting -o noexec.
>>>
>>>
>>> The only thing that concerns me with doing that is that it could result in weirdness, e.g. The osreldate.h generation script in include/ .
>>
>> It prepends 'sh'.
>>
>> include/Makefile:MK_OSRELDATE_SH= ${.CURDIR}/mk-osreldate.sh
>> include/Makefile: sh ${MK_OSRELDATE_SH}
>
> Yeah... I forgot.
>
> I wrote up that patch at iX, and it was iterated over a bit. I was just remembering what happens when you use ${SHELL} (hint: no bueno if your build is kicked off with a csh/non-POSIX sh..).
>
I actually wrote up a patch recently to use ${SH} in all places of 'sh'
and '/bin/sh', and noted on SHELL?= that was not useful to use, but did
not commit it (yet).
--
Regards,
Bryan Drewery
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJWQVEOAAoJEDXXcbtuRpfPEIwIAIBNXV6TAYDFJj8kHVlI24Rv
6z8LlWR6eFxmni4TG9KihuibzJtf7V2/C2Zun0N3KHu5/tmygLbp0PJqyCkj4dYn
QaZneBTtfMH9/Vr/b6J1V/3i33UenXgB43AdT/hlKwvYsiSIyMh6m+agIb+Eh2ay
D2NIB6B0zaSIQenX5/ZtUnDFGq4RShyKDimHGSgb0NSksdhcV/G8ayn94B2NFf/7
Y4DMqEBnfU6mYXsFRymH/9Q1behZYDpPgg7ABYpPndR9tQXXJ9/MXuyXlD05JCBa
VoNpz2nf685kIdZqYHVnpD+1Nls9vnT36eZYwtGh0U65HcqeFNTkP2qcI5VYyzw=
=2gRP
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5641510E.4020602>