Date: Fri, 23 May 2003 19:04:09 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Doug Barton <DougB@FreeBSD.org> Cc: Nate Lawson <nate@root.org> Subject: Re: cvs commit: src/sbin/newfs mkfs.c Message-ID: <20030523185605.D47768@gamplex.bde.org> In-Reply-To: <20030522163523.R2984@znfgre.qbhto.arg> References: <20030522183930.564EF37B49D@hub.freebsd.org> <20030522161035.X95941@root.org> <20030522163523.R2984@znfgre.qbhto.arg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 22 May 2003, Doug Barton wrote: > On Thu, 22 May 2003, Nate Lawson wrote: > > > Actually there's a style bug in that the chdummy line is spaces not > > tabs. This contributed to me missing it. :) > > There are other style(9) violations in that same file, so I didn't think > this one was important enough to worry about, and I wanted to get the fix > in as reviewed asap. Perhaps my judgement was faulty... mkfs.c had fewer KNF violations than most files in the system. With the exception of the declarations before the functions, I could only find formatting errors on about 13 lines using indent(1) (indent(1) with certain options fixed about 13 lines and broke about 30). The global declarations are harder to check because indent(1) would misformat them all, but they are obvioslu all misformatted because they are mostly missing tabs. The patch has several very obvious style bugs -- long lines. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030523185605.D47768>