Date: Fri, 30 Nov 2018 22:53:19 +0300 From: Andrew Rybchenko <arybchik@FreeBSD.org> To: cem@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341327 - head/sys/dev/sfxge Message-ID: <b08b0398-f06d-c3c7-c8d1-664d9b2ca1cd@oktetlabs.ru> In-Reply-To: <CAG6CVpWRrGox-sMhWbc6==EPoWoJwzHCnC0xfRbvSwYjhSwXyA@mail.gmail.com> References: <201811300711.wAU7B5R6084752@repo.freebsd.org> <d60f54ae-a1a6-bad5-73f0-c898d0579089@FreeBSD.org> <7545b110-4930-d49f-f99f-7ec17db7e7a7@oktetlabs.ru> <CAG6CVpWRrGox-sMhWbc6==EPoWoJwzHCnC0xfRbvSwYjhSwXyA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Conrad, On 30.11.2018 21:35, Conrad Meyer wrote: > On Fri, Nov 30, 2018 at 10:16 AM Andrew Rybchenko <arybchik@freebsd.org> wrote: >> Basically I'm ready to follow any sensible policy. > Hi Andrew, > > I think general policy is to not include a "Differential Revision:" > line in a commit message unless there was actual review there. I've not heard about it and have not found it anywhere written. At least it is convenient to specify, since it closes the review request automatically and keeps the track. So, I think it is better to specify, but I have no strong opinion. > (That's separate from the issue of creating a bunch of reviews that no > one will ever look at — which is a different kind of spam.) > >> Yes in this particular case these 2 hundreds of patches is the result of 2 years of development. > Why are they being committed now, hundreds at a time, instead of as > they were developed over the last two years? It is simple - had no time and had different priorities from SF. Also there are some benefits in delay - patches are more clear now since many fixes are squashed in. In any case I'll try to avoid so huge delays in the future. Andrew.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b08b0398-f06d-c3c7-c8d1-664d9b2ca1cd>