Date: Fri, 17 Dec 2004 18:04:19 -0500 From: Adam Weinberger <adamw@magnesium.net> To: Kris Kennaway <kris@obsecurity.org> Cc: cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/irc/insub pkg-plist Message-ID: <41C365F3.3090805@magnesium.net> In-Reply-To: <20041217224158.GA41450@xor.obsecurity.org> References: <200412161851.iBGIpEeq058112@repoman.freebsd.org> <1103275349.98746.10.camel@pav.hide.vol.cz> <20041217141852.GJ79222@elvis.mu.org> <1103294201.98746.33.camel@pav.hide.vol.cz> <41C359C8.6090708@magnesium.net> <20041217222734.GN79222@elvis.mu.org> <41C35FD8.4090604@magnesium.net> <20041217224158.GA41450@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway wrote: > On Fri, Dec 17, 2004 at 05:38:16PM -0500, Adam Weinberger wrote: > >>Alfred Perlstein wrote: >> >>>* Adam Weinberger <adamw@magnesium.net> [041217 14:10] wrote: >>> >>> >>>>Cowsay needs to be part of the RUN_DEPENDS anyway. Otherwise, you have a >>>>bunch of cow files around with nothing that can use them. Besides, >>>>cowsay isn't actually part of the build, anyway. >>>> >>>>Furthermore, the @unexec rm %D/share/cows 2>/dev/null|| true should be >>>>added to cowsay's pkg-plist, not insub's. >>> >>> >>>Shall I do this? >>> >> >>I think so, yes. But cowsay belongs to Kris, and you should get approval >>from him (*poke, poke, you're Cc:'ed*). > > > If insub gains a dependency on cowsay (as it should), then nothing > needs to be done to cowsay, because insub will be pkg_deleted before > cowsay, and the share/cows directory will be empty by the time cowsay > tries to remove it. > > Kris Right, but it means that every cowsay upgrade will barf error messages. Which I thought is what the 2>/dev/null||true thing was there for. # Adam -- Adam Weinberger adamw@magnesium.net || adamw@FreeBSD.org adamw@vectors.cx || adamw@gnome.org http://www.vectors.cx
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41C365F3.3090805>