Date: Sat, 16 Jun 2012 18:14:08 +0000 From: "Bjoern A. Zeeb" <bz@freebsd.org> To: Steven Chamberlain <steven@pyro.eu.org> Cc: freebsd-security@freebsd.org Subject: Re: SA-12:04 commit on RELENG_8_1 incorrect? Message-ID: <AD8A7E58-C531-4AED-9A9E-9A4773E46E73@freebsd.org> In-Reply-To: <4FDCC91A.7080403@pyro.eu.org> References: <4FDCC91A.7080403@pyro.eu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16. Jun 2012, at 17:57 , Steven Chamberlain wrote: > Hi, >=20 > This was the commit of SA-12:04.sysret to RELENG_7_4, which makes = sense > to me: >=20 > = http://svnweb.freebsd.org/base/releng/7.4/sys/amd64/amd64/trap.c?r1=3D2166= 18&r2=3D236953 >=20 > But when it was applied to RELENG_8_1, it looks wrong, as if it was > applied in the wrong place. The indentation is broken, and the code > inserted looks like it wouldn't be effective: >=20 > = http://svnweb.freebsd.org/base/releng/8.1/sys/amd64/amd64/trap.c?revision=3D= 236953&view=3Dmarkup#l965 >=20 > Please could someone take a look at this and let me know if it was > really intended. That 8.1 one is definitively wrong and had gone unnoticed. I'll make sure it'll be fixed. Thanks a lot for letting us know. /bz --=20 Bjoern A. Zeeb You have to have visions! It does not matter how good you are. It matters what good you do!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AD8A7E58-C531-4AED-9A9E-9A4773E46E73>