Date: Thu, 10 May 2018 21:26:28 -0400 From: Ed Maste <emaste@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Andrew Gallatin <gallatin@cs.duke.edu>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Konstantin Belousov <kib@freebsd.org> Subject: Re: svn commit: r333470 - in head: share/mk sys/conf Message-ID: <CAPyFy2CZ=-FfkSw04PHMTqVH9474UPNRwca1NzaioW0KDRkDZA@mail.gmail.com> In-Reply-To: <CANCZdfo=SYpEAU_tWsHowGRe50dgtt-o_KRyfB3fP09egqEFHA@mail.gmail.com> References: <201805102010.w4AKA3Ww094768@repo.freebsd.org> <788634f4-7a63-36c9-2ebd-5842d464f324@cs.duke.edu> <CAPyFy2Bpm4pcfHGMbSyL8yroBACtgsxc2wJi9jxWbq%2BNEE2wsQ@mail.gmail.com> <31075786-70ed-10b9-fbc5-127996f87b1b@cs.duke.edu> <CAPyFy2CWdhTtfMiPTTNKfOdSRP3D0V718GR3fK40r6MYtLHh%2BA@mail.gmail.com> <58b76dcb-b081-869b-8e05-dc0c4e7aa3be@cs.duke.edu> <CANCZdfo=SYpEAU_tWsHowGRe50dgtt-o_KRyfB3fP09egqEFHA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10 May 2018 at 20:38, Warner Losh <imp@bsdimp.com> wrote:
>
> It's a shame we can't get a link-time error if a too-old ld is used rather
> than silent failure.
That's what this commit does:
+.if defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc} == ""
+.error amd64 kernel requires linker ifunc support
+.endif
Making ld.bfd itself error out (e.g., if it encounters STT_GNU_IFUNC
as an unknown symbol type) could be done but would require that the
patched ld.bfd be installed, defeating the purpose.
The test has a possible false negative (producing a broken kernel
instead of an error), if LINKER_FEATURES is not defined due to some
unusual configuration. We could just drop the defined(LINKER_FEATURES)
to avoid that, and introduce a possible false positive error.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CZ=-FfkSw04PHMTqVH9474UPNRwca1NzaioW0KDRkDZA>