Date: Mon, 23 Sep 2019 11:28:52 -0700 From: Conrad Meyer <cem@freebsd.org> To: Mark Johnston <markj@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r352623 - in head/sys: amd64/amd64 kern Message-ID: <CAG6CVpUFeSTCH85NWsVXJ4Tq26R3SZn_syq2mLAc76BzgZTSTw@mail.gmail.com> In-Reply-To: <201909231414.x8NEEh9e040728@repo.freebsd.org> References: <201909231414.x8NEEh9e040728@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Mark, On Mon, Sep 23, 2019 at 7:14 AM Mark Johnston <markj@freebsd.org> wrote: > > Author: markj > Date: Mon Sep 23 14:14:43 2019 > New Revision: 352623 > URL: https://svnweb.freebsd.org/changeset/base/352623 > > Log: > Use elf_relocaddr() when handling R_X86_64_RELATIVE relocations. > > This is required for DPCPU and VNET data variable definitions to work when > KLDs are linked as DSOs. R_X86_64_RELATIVE relocations should not appear > in object files, so assert this in elf_relocaddr(). Is the goal to eventually link amd64 KLDs as DSOs? I might be confusing the terminology, but I believe amd64 .ko's today are unlinked ordinary object files, rather than shared objects. (I believe they use kern/link_elf_obj.c rather than kern/link_elf.c today.) If so: great! Thanks, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUFeSTCH85NWsVXJ4Tq26R3SZn_syq2mLAc76BzgZTSTw>