Date: Tue, 9 Apr 2024 05:08:10 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: =?UTF-8?Q?T=C4=B3l_Coosemans?= <tijl@freebsd.org> Cc: "Tobias C. Berner" <tcberner@gmail.com>, Gleb Popov <arrowd@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" Message-ID: <CAMHz58RqvKTL=5C8ZX0YsENfsgoSYhV3pdFANFX5myeVuZT-cw@mail.gmail.com> In-Reply-To: <20240331234553.1793b816@hal.tijl.coosemans.org> References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <CALH631=Q0Hc%2BYnvREbe0aNR%2BVeWaNv3YdekKmeUe_Kf6tXD6TQ@mail.gmail.com> <2567403.0dHE6SNnxz@angua.firefly> <CAMHz58Qa2pyN6qs-mFr9aHgtQoGrd1hbhF=ahx5ahR-0CB-7uQ@mail.gmail.com> <20240324202715.5d18838d@hal.tijl.coosemans.org> <CAMHz58QZ0bQh51s4j9CNt7yRZX8=uQi-cDp3ok6FN8ie0v=Gbw@mail.gmail.com> <20240331234553.1793b816@hal.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000020beb406159c362e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Mon, Apr 1, 2024 at 5:46=E2=80=AFAM T=C4=B3l Coosemans <tijl@freebsd.org=
> wrote:
> On Mon, 1 Apr 2024 04:17:09 +0800 Po-Chuan Hsieh wrote:
> > On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T=C4=B3l Coosemans <tijl@freebs=
d.org> wrote:
> >> - You are using upstream distfiles that are quite large. The distfile=
s
> >> for the common (Latin, Greek, Cyrillic) fonts Sans, Sans Mono, and
> >> Serif add up to 234MB. These fonts will be installed by almost ever=
y
> >> user that uses FreeBSD as a desktop now that DejaVu appears to have
> >> been abandoned. My proposal was to create our own distfiles and I
> >> integrated that into makesum so the only extra step compared to a
> >> normal version update was to upload the generated distfile to
> >> freefall. I was willing to take over maintainership in case you
> >> didn't want to deal with that. These distfiles add up to 27MB. And
> >> if we put the extra weights (ExtraBold,...) and widths (Condensed,..=
.)
> >> in a separate port like you did it would be only 2MB.
> >
> > The committed one is my second version of noto fonts update.
> > The previous version is to use the individual file from github.com just
> > like those Noto CJK ports.
> > I changed to upstream tarball because it's clearer/simpler and easier t=
o
> > track.
> > I could change it back to the previous version for a smaller distfile
> > footprint.
> > Give me several days to clean up the Makefiles.
>
> Okay.
>
> >> - Some fonts have been split into x11-fonts/<font>-basic providing Bol=
d,
> >> BoldItalic, Italic, and Regular, and x11-fonts/<font>-extra providin=
g
> >> additional styles. Only some of these have x11-fonts/<font> as a
> >> metaport currently. This needs to be made consistent. I think it
> >> would be best to drop the metaports and move x11-fonts/<font>-basic =
to
> >> x11-fonts/<font>. That way pkg install <font> installs the common
> >> styles for all fonts. I think that this would be the most
> >> intuitive/convenient.
> >> (I was hoping to use subpackages for this instead of extra ports.)
> >
> > The -basic/-extra structure was kept for minimal change.
> > I agree with you that it would be better to be consistent with all othe=
r
> > noto ports.
> > I could merge the following ports:
> > - noto-sans-basic/-extra
> > - noto-sans-mono-basic/-extra
> > - noto-sans-symbols-basic/-extra
> > - noto-serif-basic/-extra
> > However, what should be noto-basic's dependencies after the merge?
>
> It's okay to keep the -extra ports. What I meant was to rename the
> -basic ports so noto-sans-basic becomes noto-sans for example.
>
I've prepared a patch [1] for the following changes:
- Merge x11-fonts/noto-sans-{basic,extra} to x11-fonts/noto-sans
- Merge x11-fonts/noto-sans-mono-{basic,extra} to x11-fonts/noto-sans-mono
- Merge x11-fonts/noto-sans-symbols-{basic,extra} to
x11-fonts/noto-sans-symbols
- Merge x11-fonts/noto-serif-{basic,extra} to x11-fonts/noto-serif
- Update x11-fonts/noto-basic to depend on the 4 merged ports
- Update x11-fonts/noto-extra by removing the 4 -extra ports from
RUN_DEPENDS
[1] https://people.freebsd.org/~sunpoet/patch/noto.txt
> >> - x11/noto-emoji now installs the COLRv1 version of Noto Color Emoji b=
ut
> >> this isn't supported yet by graphics/cairo so emoji are broken now i=
n
> >> gtk applications. I think Ghostscript doesn't support it either. I=
t
> >> has to be removed again for now.
> >
> > It is handled in PR 278019 and
> > ports 2878ca490586207c3cd7bb3ff94d1274f52013b0.
>
> Okay.
>
> >> - Besides Noto Color Emoji there's also the monochrome Noto Emoji that
> >> can be useful in print. I think we should let x11-fonts/noto-emoji
> >> install the monochrome font and move the existing x11-fonts/noto-emo=
ji
> >> to x11-fonts/noto-color-emoji so the names match.
> >
> > How about putting all emoji in the existing port (x11-fonts/noto-emoji)=
?
>
> That's up to you as maintainer. I would keep them apart because they
> have different releases, version numbers and different upstreams. For
> NotoEmoji there are also additional weights you could put in an -extra
> port:
>
> NotoEmoji-Light.ttf (extra)
>
> https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGW=
uob_10jwvS-FGJCMY.ttf
> NotoEmoji-Regular.ttf
> <https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaG=
Wuob_10jwvS-FGJCMY.ttfNotoEmoji-Regular.ttf>
> (basic)
>
> https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGW=
uob-r0jwvS-FGJCMY.ttf
> NotoEmoji-Medium.ttf
> <https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaG=
Wuob-r0jwvS-FGJCMY.ttfNotoEmoji-Medium.ttf>
> (extra)
>
> https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGW=
uob-Z0jwvS-FGJCMY.ttf
> NotoEmoji-SemiBold.ttf
> <https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaG=
Wuob-Z0jwvS-FGJCMY.ttfNotoEmoji-SemiBold.ttf>
> (extra)
>
> https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGW=
uob911TwvS-FGJCMY.ttf
> NotoEmoji-Bold.ttf
> <https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaG=
Wuob911TwvS-FGJCMY.ttfNotoEmoji-Bold.ttf>
> (basic)
>
> https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGW=
uob9M1TwvS-FGJCMY.ttf
>
--00000000000020beb406159c362e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr">On Mon, Apr 1, 2024 at 5:46=E2=80=AFAM T=
=C4=B3l Coosemans <<a href=3D"mailto:tijl@freebsd.org" target=3D"_blank"=
>tijl@freebsd.org</a>> wrote:<br></div><div class=3D"gmail_quote"><block=
quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1=
px solid rgb(204,204,204);padding-left:1ex">On Mon, 1 Apr 2024 04:17:09 +08=
00 Po-Chuan Hsieh wrote:<br>
> On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T=C4=B3l Coosemans <<a href=
=3D"mailto:tijl@freebsd.org" target=3D"_blank">tijl@freebsd.org</a>> wro=
te:<br>
>> - You are using upstream distfiles that are quite large.=C2=A0 The=
distfiles<br>
>>=C2=A0 =C2=A0for the common (Latin, Greek, Cyrillic) fonts Sans, Sa=
ns Mono, and<br>
>>=C2=A0 =C2=A0Serif add up to 234MB.=C2=A0 These fonts will be insta=
lled by almost every<br>
>>=C2=A0 =C2=A0user that uses FreeBSD as a desktop now that DejaVu ap=
pears to have<br>
>>=C2=A0 =C2=A0been abandoned.=C2=A0 My proposal was to create our ow=
n distfiles and I<br>
>>=C2=A0 =C2=A0integrated that into makesum so the only extra step co=
mpared to a<br>
>>=C2=A0 =C2=A0normal version update was to upload the generated dist=
file to<br>
>>=C2=A0 =C2=A0freefall.=C2=A0 I was willing to take over maintainers=
hip in case you<br>
>>=C2=A0 =C2=A0didn't want to deal with that.=C2=A0 These distfil=
es add up to 27MB.=C2=A0 And<br>
>>=C2=A0 =C2=A0if we put the extra weights (ExtraBold,...) and widths=
(Condensed,...)<br>
>>=C2=A0 =C2=A0in a separate port like you did it would be only 2MB.=
=C2=A0 <br>
> <br>
> The committed one is my second version of noto fonts update.<br>
> The previous version is to use the individual file from <a href=3D"htt=
p://github.com" rel=3D"noreferrer" target=3D"_blank">github.com</a> just<br=
>
> like those Noto CJK ports.<br>
> I changed to upstream tarball because it's clearer/simpler and eas=
ier to<br>
> track.<br>
> I could change it back to the previous version for a smaller distfile<=
br>
> footprint.<br>
> Give me several days to clean up the Makefiles.<br>
<br>
Okay.<br>
<br>
>> - Some fonts have been split into x11-fonts/<font>-basic pro=
viding Bold,<br>
>>=C2=A0 =C2=A0BoldItalic, Italic, and Regular, and x11-fonts/<fon=
t>-extra providing<br>
>>=C2=A0 =C2=A0additional styles.=C2=A0 Only some of these have x11-f=
onts/<font> as a<br>
>>=C2=A0 =C2=A0metaport currently.=C2=A0 This needs to be made consis=
tent.=C2=A0 I think it<br>
>>=C2=A0 =C2=A0would be best to drop the metaports and move x11-fonts=
/<font>-basic to<br>
>>=C2=A0 =C2=A0x11-fonts/<font>.=C2=A0 That way pkg install <=
;font> installs the common<br>
>>=C2=A0 =C2=A0styles for all fonts.=C2=A0 I think that this would be=
the most<br>
>>=C2=A0 =C2=A0intuitive/convenient.<br>
>>=C2=A0 =C2=A0(I was hoping to use subpackages for this instead of e=
xtra ports.)<br>
> <br>
> The -basic/-extra structure was kept for minimal change.<br>
> I agree with you that it would be better to be consistent with all oth=
er<br>
> noto ports.<br>
> I could merge the following ports:<br>
> - noto-sans-basic/-extra<br>
> - noto-sans-mono-basic/-extra<br>
> - noto-sans-symbols-basic/-extra<br>
> - noto-serif-basic/-extra<br>
> However, what should be noto-basic's dependencies after the merge?=
<br>
<br>
It's okay to keep the -extra ports.=C2=A0 What I meant was to rename th=
e<br>
-basic ports so noto-sans-basic becomes noto-sans for example.<br></blockqu=
ote><div><br></div><div>I've prepared a patch [1] for the following cha=
nges:</div><div>- Merge x11-fonts/noto-sans-{basic,extra} to x11-fonts/noto=
-sans</div><div>- Merge x11-fonts/noto-sans-mono-{basic,extra} to x11-fonts=
/noto-sans-mono</div><div>- Merge x11-fonts/noto-sans-symbols-{basic,extra}=
to x11-fonts/noto-sans-symbols</div><div>- Merge x11-fonts/noto-serif-{bas=
ic,extra} to x11-fonts/noto-serif</div><div>- Update=C2=A0x11-fonts/noto-ba=
sic to depend on the 4 merged ports</div><div>- Update=C2=A0x11-fonts/noto-=
extra by removing the 4 -extra ports from RUN_DEPENDS</div><div><br></div><=
div>[1]=C2=A0=C2=A0<a href=3D"https://people.freebsd.org/~sunpoet/patch/not=
o.txt" target=3D"_blank">https://people.freebsd.org/~sunpoet/patch/noto.txt=
</a></div><div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:=
0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
>> - x11/noto-emoji now installs the COLRv1 version of Noto Color Emo=
ji but<br>
>>=C2=A0 =C2=A0this isn't supported yet by graphics/cairo so emoj=
i are broken now in<br>
>>=C2=A0 =C2=A0gtk applications.=C2=A0 I think Ghostscript doesn'=
t support it either.=C2=A0 It<br>
>>=C2=A0 =C2=A0has to be removed again for now.<br>
> <br>
> It is handled in PR 278019 and<br>
> ports 2878ca490586207c3cd7bb3ff94d1274f52013b0.<br>
<br>
Okay.<br>
<br>
>> - Besides Noto Color Emoji there's also the monochrome Noto Em=
oji that<br>
>>=C2=A0 =C2=A0can be useful in print.=C2=A0 I think we should let x1=
1-fonts/noto-emoji<br>
>>=C2=A0 =C2=A0install the monochrome font and move the existing x11-=
fonts/noto-emoji<br>
>>=C2=A0 =C2=A0to x11-fonts/noto-color-emoji so the names match.<br>
> <br>
> How about putting all emoji in the existing port (x11-fonts/noto-emoji=
)?<br>
<br>
That's up to you as maintainer.=C2=A0 I would keep them apart because t=
hey<br>
have different releases, version numbers and different upstreams.=C2=A0 For=
<br>
NotoEmoji there are also additional weights you could put in an -extra<br>
port:<br>
<br>
NotoEmoji-Light.ttf (extra)<br>
<a href=3D"https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs=
-ar6uWaGWuob_10jwvS-FGJCMY.ttfNotoEmoji-Regular.ttf" rel=3D"noreferrer" tar=
get=3D"_blank">https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aW=
jPDs-ar6uWaGWuob_10jwvS-FGJCMY.ttf<br>
NotoEmoji-Regular.ttf</a> (basic)<br>
<a href=3D"https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs=
-ar6uWaGWuob-r0jwvS-FGJCMY.ttfNotoEmoji-Medium.ttf" rel=3D"noreferrer" targ=
et=3D"_blank">https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWj=
PDs-ar6uWaGWuob-r0jwvS-FGJCMY.ttf<br>
NotoEmoji-Medium.ttf</a> (extra)<br>
<a href=3D"https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs=
-ar6uWaGWuob-Z0jwvS-FGJCMY.ttfNotoEmoji-SemiBold.ttf" rel=3D"noreferrer" ta=
rget=3D"_blank">https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6a=
WjPDs-ar6uWaGWuob-Z0jwvS-FGJCMY.ttf<br>
NotoEmoji-SemiBold.ttf</a> (extra)<br>
<a href=3D"https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs=
-ar6uWaGWuob911TwvS-FGJCMY.ttfNotoEmoji-Bold.ttf" rel=3D"noreferrer" target=
=3D"_blank">https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPD=
s-ar6uWaGWuob911TwvS-FGJCMY.ttf<br>
NotoEmoji-Bold.ttf</a> (basic)<br>
<a href=3D"https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs=
-ar6uWaGWuob9M1TwvS-FGJCMY.ttf" rel=3D"noreferrer" target=3D"_blank">https:=
//fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuob9M1Tw=
vS-FGJCMY.ttf</a><br>
</blockquote></div></div>
--00000000000020beb406159c362e--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58RqvKTL=5C8ZX0YsENfsgoSYhV3pdFANFX5myeVuZT-cw>