Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 8 Nov 2003 19:55:31 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Ruslan Ermilov <ru@freebsd.org>
Cc:        cvs-all@freebsd.org
Subject:   Re: cvs commit: src/contrib/gcc c-lex.c
Message-ID:  <20031108194726.M674@gamplex.bde.org>
In-Reply-To: <20031107160744.GA47423@sunbay.com>
References:  <200311070330.hA73UWPR092624@repoman.freebsd.org> <200311070327.hA73RWjs092423@repoman.freebsd.org> <20031107084045.GD86943@sunbay.com> <20031107160744.GA47423@sunbay.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 7 Nov 2003, Ruslan Ermilov wrote:

> On Sat, Nov 08, 2003 at 02:36:09AM +1100, Bruce Evans wrote:
> > On Fri, 7 Nov 2003, Ruslan Ermilov wrote:
> >
> > > On Thu, Nov 06, 2003 at 07:09:40PM -0800, Alexander Kabaev wrote:
> > > > kan         2003/11/06 19:09:40 PST
> > > >
> > > >   FreeBSD src repository
> > > >
> > > >   Modified files:
> > > >     contrib/gcc          c-lex.c
> > > >   Log:
> > > >   Drop the revision 1.2 (don't let gcc(1) hide warnings in system headers)
> > > >   and use stock version of this file now.
> > > >   ...
> > >
> > > Will -Wsystem-headers from bsd.sys.mk for WARNS > 0 still take care
> > > of emitting warnings in system headers?
> >
> > If WARNS > 0 it will :-).  I think we have enough WARNS > 0 to catch
> > most problems, but developers, especially bde and ru, should run with
> > -Wsystem-headers unconditional in bsd.sys.mk.
> >
> I mean, does -Wsystem-headers affect both cc(1) and cpp(1) now?

Yes, but I think your question is whether we enable it for cpp.  We don't
do anything except enable it in CFLAGS if WARNS > 0 AFAIK, so only
invocations of cpp that use CFLAGS get it.  This may be enough.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031108194726.M674>