Date: Fri, 17 Dec 2010 20:04:50 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: freebsd-multimedia@freebsd.org, Martin Matuska <mm@freebsd.org> Subject: Re: ffmpeg and mmap Message-ID: <20101217180450.GQ33073@deviant.kiev.zoral.com.ua> In-Reply-To: <4D0B9752.6020308@freebsd.org> References: <4D05332C.7010208@freebsd.org> <4D0B9752.6020308@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--wZTxhqwJpWaw9Sch Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 17, 2010 at 07:01:06PM +0200, Andriy Gapon wrote: > The above check should also be fixed for the case when mmap is used. > mmap returns MAP_FAILED in case of failure and on FreeBSD MAP_FAILED != NULL. > Not sure about Linux, but we probably don't care - if only to report to upstream > to make their code cleaner. NULL is the valid return value from mmap() for FreeBSD address map both on i386 and amd64. --wZTxhqwJpWaw9Sch Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk0LpkIACgkQC3+MBN1Mb4hVpQCgrRYYi+m0Wd7VbPfjzHBSwUIq 4IkAni1kRI8bGUQhDw8iZ16PG+6KKzK3 =Q/s4 -----END PGP SIGNATURE----- --wZTxhqwJpWaw9Sch--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101217180450.GQ33073>