Date: Wed, 24 Mar 2010 11:32:29 -0400 From: John Baldwin <jhb@freebsd.org> To: Alexander Leidinger <Alexander@leidinger.net> Cc: rwatson@freebsd.org, freebsd-arch@freebsd.org Subject: Re: CTF patch for testing/review Message-ID: <201003241132.29588.jhb@freebsd.org> In-Reply-To: <20100324154214.16865r6wk0r22rcw@webmail.leidinger.net> References: <20100322.125937.278730673160410010.imp@bsdimp.com> <201003241005.55239.jhb@freebsd.org> <20100324154214.16865r6wk0r22rcw@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 24 March 2010 10:42:14 am Alexander Leidinger wrote:
> Quoting John Baldwin <jhb@freebsd.org> (from Wed, 24 Mar 2010 10:05:55
-0400):
>
> > On Wednesday 24 March 2010 9:59:41 am Alexander Leidinger wrote:
>
> >> Currently I have the problem that WITH_CTF is not picked up by kmod.mk
> >> if "makeoptions WITH_CTF=yes" is used in the kernel config. This means
> >> that all makeoptions do not propagate to module builds.
> >>
> >> Any ideas?
> >
> > Hmmmm. That's odd because 'DEBUG=-g' does work. Ah, I think you should
> > patch kern.post.mk to propogate WITH_CTF to modules. This is how it works
> > for DEBUG now:
> >
> > .if defined(DEBUG)
> > MKMODULESENV+= DEBUG_FLAGS="${DEBUG}"
> > .endif
>
> Do we want to be able to override WITH_CTF in modules (-> kern.pre.mk
> instead of kernl.post.mk)?
No, I think it is fine to treat it the same as DEBUG.
> While I'm here, do we want to have CONF_CFLAGS used in modules too? I
> would expect that they are used there (I use it to use -fno-builtin
> for my kernel build) and would put it into kern.post.mk.
Hmm, probably yes. That should be a separate commit however.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003241132.29588.jhb>