Date: Sun, 22 Sep 2013 06:33:29 -0600 From: "Justin T. Gibbs" <gibbs@freebsd.org> To: Aryeh Friedman <aryeh.friedman@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r255783 - head/sys/kern Message-ID: <A96D6D9A-F38D-4B4D-87DA-F8088F7D1E45@freebsd.org> In-Reply-To: <CAGBxaX=_DKMFyHBHq4hJtFoGw_K7o=xQzeuh-6NdtFoORJ8XAw@mail.gmail.com> References: <201309220246.r8M2kEIN054172@svn.freebsd.org> <CAGBxaX=_DKMFyHBHq4hJtFoGw_K7o=xQzeuh-6NdtFoORJ8XAw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 22, 2013, at 12:38 AM, Aryeh Friedman <aryeh.friedman@gmail.com> = wrote: > On Sat, Sep 21, 2013 at 10:46 PM, Justin T. Gibbs <gibbs@freebsd.org> = wrote: > Author: gibbs > Date: Sun Sep 22 02:46:13 2013 > New Revision: 255783 > URL: http://svnweb.freebsd.org/changeset/base/255783 >=20 > Log: > Fix ia64 and mips kernel builds due to XENHVM=3D>GENERIC integration = in > revision 255744. >=20 > sys/kern/subr_smp.c: > IPI_SUSPEND is only available on amd64 and i386. Protect > new uses of this constant with #ifdefs to avoid impacting > other platforms. >=20 > Approved by: re (blanket Xen) >=20 > Modified: > head/sys/kern/subr_smp.c >=20 > Modified: head/sys/kern/subr_smp.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/kern/subr_smp.c Sun Sep 22 02:14:54 2013 = (r255782) > +++ head/sys/kern/subr_smp.c Sun Sep 22 02:46:13 2013 = (r255783) > @@ -225,6 +225,7 @@ generic_stop_cpus(cpuset_t map, u_int ty > CTR2(KTR_SMP, "stop_cpus(%s) with %u type", > cpusetobj_strprint(cpusetbuf, &map), type); >=20 > +#if defined(__amd64__) || defined(__i386__) > /* > * When suspending, ensure there are are no IPIs in progress. > * IPIs that have been issued, but not yet delivered (e.g. > @@ -234,6 +235,7 @@ generic_stop_cpus(cpuset_t map, u_int ty > */ > if (type =3D=3D IPI_SUSPEND) > mtx_lock_spin(&smp_ipi_mtx); > +#endif >=20 > if (stopping_cpu !=3D PCPU_GET(cpuid)) > while (atomic_cmpset_int(&stopping_cpu, NOCPU, > @@ -262,8 +264,10 @@ generic_stop_cpus(cpuset_t map, u_int ty > } > } >=20 > +#if defined(__amd64__) || defined(__i386__) > if (type =3D=3D IPI_SUSPEND) > mtx_unlock_spin(&smp_ipi_mtx); > +#endif >=20 > stopping_cpu =3D NOCPU; > return (1); > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >=20 >=20 > This seems to cause a kernel panic if the machine is left idle for too = long Seeing the actual panic text would help me to address the issue. -- Justin=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A96D6D9A-F38D-4B4D-87DA-F8088F7D1E45>