Date: Sun, 10 Mar 2019 17:16:40 -0500 From: Justin Hibbits <chmeeedalf@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Justin Hibbits <jhibbits@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344960 - head/sys/powerpc/powerpc Message-ID: <20190310171640.31bb9c54@titan.knownspace> In-Reply-To: <20190309085058.GA60945@FreeBSD.org> References: <201903090318.x293IcLc023548@repo.freebsd.org> <20190309085058.GA60945@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 9 Mar 2019 08:50:58 +0000 Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Sat, Mar 09, 2019 at 03:18:38AM +0000, Justin Hibbits wrote: > > New Revision: 344960 > > URL: https://svnweb.freebsd.org/changeset/base/344960 > > > > Log: > > powerpc: Print trap frame address for fatal traps > > > > MFC after: 1 week > > > > Modified: > > head/sys/powerpc/powerpc/trap.c > > > > Modified: head/sys/powerpc/powerpc/trap.c > > ============================================================================== > > --- head/sys/powerpc/powerpc/trap.c Sat Mar 9 03:15:09 > > 2019 (r344959) +++ head/sys/powerpc/powerpc/trap.c > > Sat Mar 9 03:18:37 2019 (r344960) @@ -546,6 +546,7 @@ > > printtrap(u_int vector, struct trapframe *frame, int i printf(" > > current msr = 0x%" PRIxPTR "\n", mfmsr()); printf(" > > lr = 0x%" PRIxPTR " (0x%" PRIxPTR ")\n", frame->lr, > > frame->lr - (register_t)(__startkernel - KERNBASE)); > > + printf(" frame = %p\n", frame); > > printf(" curthread = %p\n", curthread); > > Some of those are printed with %PRIxPTR, some with %p. Perhaps this > inconsistency can be avoided? > > ./danfe PRIxPTR is for printing a pointer-like value that's not a pointer. The other values printed are of type register_t, not void *. - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190310171640.31bb9c54>