Date: Sat, 2 May 2020 13:07:32 -0600 From: Warner Losh <imp@bsdimp.com> To: Colin Percival <cperciva@tarsnap.com> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r360508 - head/sys/cam/nvme Message-ID: <CANCZdfro-1o-r1eb5w18ECkMNMa3-xyTM=YUhxgunK3ux=mtgw@mail.gmail.com> In-Reply-To: <01000171d6ab14d7-e7c44f4c-9bc1-4bb4-93e0-09cc66b777e2-000000@email.amazonses.com> References: <202004302108.03UL8xks087664@repo.freebsd.org> <01000171d6ab14d7-e7c44f4c-9bc1-4bb4-93e0-09cc66b777e2-000000@email.amazonses.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 2, 2020, 12:34 PM Colin Percival <cperciva@tarsnap.com> wrote: > On 2020-04-30 14:08, Warner Losh wrote: > > Author: imp > > Date: Thu Apr 30 21:08:59 2020 > > New Revision: 360508 > > URL: https://svnweb.freebsd.org/changeset/base/360508 > > > > - Unlock the periph before returning. We don't need to relock it to > > release the ccb. > > You sure about that? I'm getting a panic here: > > panic: mutex CAM device lock not owned at /usr/src/sys/cam/cam_xpt.c:3983 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > 0xfffffe00d8243430 > vpanic() at vpanic+0x182/frame 0xfffffe00d8243480 > panic() at panic+0x43/frame 0xfffffe00d82434e0 > __mtx_assert() at __mtx_assert+0xb0/frame 0xfffffe00d82434f0 > xpt_release_ccb() at xpt_release_ccb+0x30/frame 0xfffffe00d8243520 > ndaioctl() at ndaioctl+0x241/frame 0xfffffe00d8243730 > Hmmm... I'm not.. I need to figure out why... I thought I was running with invariants... Warner -- > Colin Percival > Security Officer Emeritus, FreeBSD | The power to serve > Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfro-1o-r1eb5w18ECkMNMa3-xyTM=YUhxgunK3ux=mtgw>