Date: Sat, 23 Nov 2019 07:41:21 -0600 From: Kyle Evans <kevans@freebsd.org> To: Mark Millard <marklmi@yahoo.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: head r355027 fails to (non-debug) build for: sys/arm/broadcom/bcm2835/bcm2835_sdhci.c:721:26: error: unused variable 'sc Message-ID: <CACNAnaGHOoTtqbOOZ9oRcCLcSH_NE=L6fXBA2PtSGh1T19mXDA@mail.gmail.com> In-Reply-To: <CB176B47-1E47-439E-9B4A-8F36A7C2DDD3@yahoo.com> References: <CB176B47-1E47-439E-9B4A-8F36A7C2DDD3.ref@yahoo.com> <CB176B47-1E47-439E-9B4A-8F36A7C2DDD3@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 23, 2019 at 2:42 AM Mark Millard <marklmi@yahoo.com> wrote:
>
> --- bcm2835_sdhci.o ---
> /usr/src/sys/arm/broadcom/bcm2835/bcm2835_sdhci.c:721:26: error: unused variable 'sc' [-Werror,-Wunused-variable]
> struct bcm_sdhci_softc *sc = device_get_softc(slot->bus);
> ^
> 1 error generated.
>
> This is because the sc is only used in:
>
> KASSERT(sc->dmamap_seg_count == 0,
> ("data pending interrupt pushed through SDHCI framework"));
>
> and this was a non-debug build: so the KASSERT did not use sc either.
>
>
Whoops, sorry about that! Fixed in r355031.
Thanks,
Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaGHOoTtqbOOZ9oRcCLcSH_NE=L6fXBA2PtSGh1T19mXDA>