Date: Tue, 15 Apr 2003 11:17:13 -0400 (EDT) From: "Matthew N. Dodd" <mdodd@FreeBSD.ORG> To: "M. Warner Losh" <imp@bsdimp.com> Cc: arch@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c Message-ID: <20030415111653.F99028@sasami.jurai.net> In-Reply-To: <20030415.091209.108403664.imp@bsdimp.com> References: <20030415102955.S99028@sasami.jurai.net> <20030415.083615.91276433.imp@bsdimp.com> <20030415.091209.108403664.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 15 Apr 2003, M. Warner Losh wrote:
> foo |= BIT;
> if ((foo & BIT) == 0)
> whine-and-fail;
Indeed.
> is that what you are saying?
>
> : This would keep drivers from having to check and see if PCIM_CMD_PORTEN or
> : PCIM_CMD_MEMEN is set.
>
> Yes.
>
> : This requires changing the definition of the 'enable_io' method.
> :
> : Since we're here we should change 'disable_io' and
> : '{enable,disable}_busmaster' as well.
>
> If we're going to do this, then we need to do it soon.
I'm working on patches.
--
| Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD |
| winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax |
| http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030415111653.F99028>