Date: Thu, 13 May 2021 20:52:05 +0200 From: Gary Jennejohn <gljennjohn@gmail.com> To: Lev Serebryakov <lev@FreeBSD.org> Cc: Henri Hennebert <hlh@restart.be>, Marc Veldman <marc@bumblingdork.com>, freebsd-current@freebsd.org Subject: Re: CURRENT crashes at early boot on Lenovo T540p: rtsx to blame - 13.0-RELEASE crashes same way! Message-ID: <20210513185205.17816dc5@ernst.home> In-Reply-To: <ac486329-36cf-1a3d-063e-d89b174e2f14@FreeBSD.org> References: <a7363387-c53f-d6c0-acc0-be9081590ea1@FreeBSD.org> <9f0abf48-ed13-bff3-5687-fca0d57195d8@restart.be> <C4E25C70-25BA-4BEB-83F0-D77279B2B94A@bumblingdork.com> <8d4e076b-9ecd-aef2-0ee8-73519bb9d939@FreeBSD.org> <8d2be5f2-4144-082e-4237-0dac0c4b37e6@restart.be> <f084b1c8-5020-2db9-6cf3-47641066bb69@FreeBSD.org> <6798878a-c499-d78d-e96d-d744513cb80d@restart.be> <a630c8a3-a9d7-c6f5-111c-be0e64db1ec6@FreeBSD.org> <1de588e2-20cb-3206-3aea-f3f88f577675@restart.be> <c324501a-6a8e-f8aa-3ecd-e8d7d3485e2c@FreeBSD.org> <e20d2d7d-8584-bb6b-465d-83a5b63f8210@restart.be> <67f0874a-6a05-67f1-3f2b-c4b3dc67fa11@FreeBSD.org> <83b823bf-c6c2-2f6a-b5dd-2e91b4d1931e@restart.be> <2c208bbc-5adc-2327-4717-a5e7c8d64b4b@FreeBSD.org> <9a15daa7-2b17-e257-d4d1-850c632a9db8@restart.be> <417a97b9-2c40-310c-c445-b193c493b880@FreeBSD.org> <7eb763ce-0bbf-9baf-2ede-968ee25cff2e@restart.be> <ac486329-36cf-1a3d-063e-d89b174e2f14@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 13 May 2021 20:55:20 +0300 Lev Serebryakov <lev@FreeBSD.org> wrote: > On 13.05.2021 18:56, Henri Hennebert wrote: > > > So if I understand correctly, your problem is solved. > Stupid me. I didn't check card insertion/removal after boot. > > Card REMOVAL when boot was WITH CARD: > Instant panic: > > rtsx0: Interrupt card inserted/removed > rtsx0: Card absent > panic: mutex Giant not owned at /usr/src/sys/kern/subr_bus.c:3045 > cpuid = 3 > time = 1620928154 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c6a989c0 > vpanic() at vpanic+0x181/frame 0xfffffe00c6a98a10 > panic() at panic+0x43/frame 0xfffffe00c6a98a70 > __mtx_assert() at __mtx_assert+0xb0/frame 0xfffffe00c6a98a80 > device_detach() at device_detach+0x2e/frame 0xfffffe00c6a98ac0 > device_delete_child() at device_delete_child+0x15/frame 0xfffffe00c6a98ae0 > rtsx_card_task() at rtsx_card_task+0xfa/frame 0xfffffe00c6a98b00 > taskqueue_run_locked() at taskqueue_run_locked+0xaa/frame 0xfffffe00c6a98b80 > taskqueue_thread_loop() at taskqueue_thread_loop+0x94/frame 0xfffffe00c6a98bb0 > fork_exit() at fork_exit+0x80/frame 0xfffffe00c6a98bf0 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00c6a98bf0 > --- trap 0, rip = 0, rsp = 0, rbp = 0 --- > KDB: enter: panic > > Card INSERTION when boot was WITHOUT CARD: > Instant panic: > > rtsx0: Interrupt card inserted/removed > rtsx0: Card present > panic: mutex Giant not owned at /usr/src/sys/kern/subr_bus.c:2944 > cpuid = 1 > time = 1620928312 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00c6a98a10 > vpanic() at vpanic+0x181/frame 0xfffffe00c6a98a60 > panic() at panic+0x43/frame 0xfffffe00c6a98ac0 > __mtx_assert() at __mtx_assert+0xb0/frame 0xfffffe00c6a98ad0 > device_probe_and_attach() at device_probe_and_attach+0x2a/frame 0xfffffe00c6a98b00 > taskqueue_run_locked() at taskqueue_run_locked+0xaa/frame 0xfffffe00c6a98b80 > taskqueue_thread_loop() at taskqueue_thread_loop+0x94/frame 0xfffffe00c6a98bb0 > fork_exit() at fork_exit+0x80/frame 0xfffffe00c6a98bf0 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00c6a98bf0 > --- trap 0, rip = 0, rsp = 0, rbp = 0 --- > KDB: enter: panic > > Both panics are "debuggable", as keyboard is working in ddb and crash dump could be created. And I'm not sure, that GIANT in 2021 is good thing. > Yeah, I was wondering about that myself when looked at the code today. The driver was originally developed when current was what is now 12 or 13, I think. Might be worth looking at dwmmc.c (where I got the card insertion/removal code) to see whether there are any recent changes there. -- Gary Jennejohn
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210513185205.17816dc5>