Date: Sat, 25 Jan 2014 15:36:22 -0500 From: Julio Merino <julio@meroh.net> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: freebsd-testing@freebsd.org, Giorgos Keramidas <keramida@freebsd.org> Subject: Re: [PATCH] convert bin/date over to ATF Message-ID: <CADyfeQXG6KGwgT1X90Ymr%2BFYnwL74H_G2zBvkgdzEhPospNM8A@mail.gmail.com> In-Reply-To: <FA467521-BB53-47C0-BAE1-8BCAE29F922F@gmail.com> References: <6079AD8F-5EBB-431C-A06B-9B51E2729F5A@gmail.com> <B90AA730-B7B8-4F1A-9D07-67861C9A6401@meroh.net> <FA467521-BB53-47C0-BAE1-8BCAE29F922F@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 23, 2014 at 5:16 PM, Garrett Cooper <yaneurabeya@gmail.com> wrote:
> On Jan 22, 2014, at 3:56 PM, Julio Merino <julio@meroh.net> wrote:
>
>> On Jan 20, 2014, at 13:40, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>>
>>> This is based on work done by Giorgos a couple years ago.
>>> Thanks!
>>> -Garrett
>>
>> Pasting patch contents and commenting inline:
>>
>>> diff --git a/bin/date/tests/Makefile b/bin/date/tests/Makefile
>>> index 540008b..459d019 100644
>>> --- a/bin/date/tests/Makefile
>>> +++ b/bin/date/tests/Makefile
>>> @@ -4,6 +4,6 @@
>>>
>>> TESTSDIR= ${TESTSBASE}/bin/date
>>>
>>> -TAP_TESTS_SH= legacy_test
>>> +ATF_TESTS_SH= regress
>>
>> Tests ought to end with _test per the description in https://wiki.freebsd.org/TestSuite/Structure
>
> Ok! Is `_tests` ok?
_test is a very common convention "out there"; I've seen it used
pretty much everywhere plus we already have a bunch of _test programs.
I don't think diverging to _tests is a good idea.
(The rationale for _test, I believe, is that this refers to the "test
program", not its contents. But who knows -- I'm just making that up.)
>> Also, "regress_test" is not a very indicative name. Will this only contain test cases for bugs to prevent regressions?
>
> It should be “date_functional_tests”, because that’s what they’re doing.
Sure; the more descriptive, the better. (But note that this will live
in a "date" subdirectory, so arguably functional_test is enough.)
--
Julio Merino / @jmmv
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADyfeQXG6KGwgT1X90Ymr%2BFYnwL74H_G2zBvkgdzEhPospNM8A>