Date: Mon, 02 Jan 2017 22:54:08 +0000 From: Conrad Meyer <cem@freebsd.org> To: Pedro Giffuni <pfg@freebsd.org>, cem@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311109 - head/usr.bin/patch Message-ID: <CAG6CVpV7=Dx6VywV0MRY7z7LMwQrBcb-1qUhjngxjFsSZZHvHg@mail.gmail.com> In-Reply-To: <aa9172cb-cb95-36cf-c21d-48f8a7450ad5@FreeBSD.org> References: <201701021823.v02INWXc028047@repo.freebsd.org> <CAG6CVpUUFoTZBO0Ja2aSn%2BeMi_BO0u131YKQ1yQumu%2BdRhVY3A@mail.gmail.com> <aa9172cb-cb95-36cf-c21d-48f8a7450ad5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I was suggesting using UINT32_MAX/2 on all platforms (which is safe everywhere). Best, Conrad On Mon, Jan 2, 2017 at 11:48 AM Pedro Giffuni <pfg@freebsd.org> wrote: > Hi; > > > > On 01/02/17 13:28, Conrad Meyer wrote: > > > IMO this patch was mostly fine, you just need to restrict line length > > > to UINT32_MAX/2 instead of UINT_MAX (== UINT32_MAX) for 32-bit > > > platforms. > > > > > > Best, > > > Conrad > > > > > > > I dislike the idea of special cases for some platforms. I guess moving > > to int/INT_MAX would be the way to go. > > > > TBH, no one has asked for patches wider than USHRT_MAX though. > > > > Pedro. > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpV7=Dx6VywV0MRY7z7LMwQrBcb-1qUhjngxjFsSZZHvHg>