Date: Sat, 10 Jun 2006 15:43:31 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/gnu/fs/xfs/FreeBSD xfs_mountops.c Message-ID: <20060610154331.5ad36dd3@kan.dnsalias.net> In-Reply-To: <200606101904.k5AJ4Lol074220@repoman.freebsd.org> References: <200606101904.k5AJ4Lol074220@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, 10 Jun 2006 19:04:21 +0000 (UTC) Craig Rodrigues <rodrigc@FreeBSD.org> wrote: > rodrigc 2006-06-10 19:04:21 UTC > > FreeBSD src repository > > Modified files: > sys/gnu/fs/xfs/FreeBSD xfs_mountops.c > Log: > Call g_vfs_close() if: > (1) _xfs_mount() fails > (2) at the end of _xfs_unmount() > > Revision Changes Path > 1.6 +36 -3 src/sys/gnu/fs/xfs/FreeBSD/xfs_mountops.c > > http://cvsweb.FreeBSD.org/src/sys/gnu/fs/xfs/FreeBSD/xfs_mountops.c.diff?r1=1.5&r2=1.6 This is plain wrong. XFS was responsible in the past for releasing all devices it opened, and that should get fixed if it got broken somehow instead of adding ad-hoc patches to plaster over the real issue. -- Alexander Kabaev [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEiyDmQ6z1jMm+XZYRAigLAJ9jS1oJoBKWr5Vianpf38s7I/R6pwCg6NEy nEvpeJX0rRhJTVXkh8DQh/c= =eQnq -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060610154331.5ad36dd3>