Date: Wed, 19 Sep 2018 10:08:16 -0700 From: Mark Millard <marklmi@yahoo.com> To: Sean Bruno <sbruno@freebsd.org> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: Some delete-old detrius Message-ID: <446D76C1-4563-43FA-8B25-3A84245385F7@yahoo.com> In-Reply-To: <d2a317ae-87d6-9671-c0f5-5923a08fca93@freebsd.org> References: <26183B75-2CBD-4D98-A59F-85617D5D18E2@yahoo.com> <d2a317ae-87d6-9671-c0f5-5923a08fca93@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2018-Sep-19, at 9:14 AM, Sean Bruno <sbruno at freebsd.org> wrote: > On 9/18/18 8:48 PM, Mark Millard wrote: >> A problem here is that the references should be to usr.bin instead >> of usr/bin . See: >>=20 >> = https://lists.freebsd.org/pipermail/svn-src-head/2018-September/118426.htm= l >>=20 >> which reports for svn commit: r336601 - head: >>=20 >> QUOTE >> Looks like this head/ObsoleteFiles.inc update has a typo >> in each thing added to OLD_FILES . . . >>=20 >> # ls -lTdt /usr/tests/usr.bin/indent/* >> -r--r--r-- 1 root wheel 121 Sep 13 22:53:30 2018 = /usr/tests/usr.bin/indent/Kyuafile >> . . . >> -r--r--r-- 1 root wheel 295 Sep 13 22:53:29 2018 = /usr/tests/usr.bin/indent/binary.0 >> -r--r--r-- 1 root wheel 92 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/sac.0.pro >> -r--r--r-- 1 root wheel 130 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/sac.0.stdout >> -r--r--r-- 1 root wheel 122 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/sac.0 >> -r--r--r-- 1 root wheel 94 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/nsac.0.pro >> -r--r--r-- 1 root wheel 130 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/nsac.0.stdout >> -r--r--r-- 1 root wheel 123 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/nsac.0 >>=20 >> vs. ( note usr.bin vs. usr/bin ): >>=20 >> Modified: head/ObsoleteFiles.inc >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/ObsoleteFiles.inc Sun Jul 22 12:04:21 2018 = (r336600) >> +++ head/ObsoleteFiles.inc Sun Jul 22 12:45:02 2018 = (r336601) >> @@ -38,6 +38,13 @@ >> # xargs -n1 | sort | uniq -d; >> # done >>=20 >> +# 20180722: indent(1) option renamed, test files follow >> +OLD_FILES+=3Dusr/bin/indent/tests/nsac.0 >> +OLD_FILES+=3Dusr/bin/indent/tests/nsac.0.pro >> +OLD_FILES+=3Dusr/bin/indent/tests/nsac.0.stdout >> +OLD_FILES+=3Dusr/bin/indent/tests/sac.0 >> +OLD_FILES+=3Dusr/bin/indent/tests/sac.0.pro >> +OLD_FILES+=3Dusr/bin/indent/tests/sac.0.stdout >> # 20180721: move of libmlx5.so.1 and libibverbs.so.1 >> OLD_LIBS+=3Dusr/lib/libmlx5.so.1 >> OLD_LIBS+=3Dusr/lib/libibverbs.so.1 >> END QUOTE >>=20 >> This was after having the nsac and sac kyua tests report >> failures in my environment, long after they should have >> not existed. >>=20 >>=20 >>=20 >> =3D=3D=3D >> Mark Millard >> marklmi at yahoo.com >> ( dsl-only.net went >> away in early 2018-Mar) >>=20 >>=20 >=20 > So, what should we even do here? It sort of looks like this entire > section should be purged or something. >=20 > There was a bit of error committing this section I guess. As near as I can tell the fix would be something like: # svnlite diff /usr/src/ObsoleteFiles.inc Index: /usr/src/ObsoleteFiles.inc =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /usr/src/ObsoleteFiles.inc (revision 338675) +++ /usr/src/ObsoleteFiles.inc (working copy) @@ -48,12 +48,12 @@ # 20180725: Cleanup old libcasper.so.0 OLD_LIBS+=3Dlib/libcasper.so.0 # 20180722: indent(1) option renamed, test files follow -OLD_FILES+=3Dusr/bin/indent/tests/nsac.0 -OLD_FILES+=3Dusr/bin/indent/tests/nsac.0.pro -OLD_FILES+=3Dusr/bin/indent/tests/nsac.0.stdout -OLD_FILES+=3Dusr/bin/indent/tests/sac.0 -OLD_FILES+=3Dusr/bin/indent/tests/sac.0.pro -OLD_FILES+=3Dusr/bin/indent/tests/sac.0.stdout +OLD_FILES+=3Dusr/tests/usr.bin/indent/nsac.0 +OLD_FILES+=3Dusr/tests/usr.bin/indent/nsac.0.pro +OLD_FILES+=3Dusr/tests/usr.bin/indent/nsac.0.stdout +OLD_FILES+=3Dusr/tests/usr.bin/indent/sac.0 +OLD_FILES+=3Dusr/tests/usr.bin/indent/sac.0.pro +OLD_FILES+=3Dusr/tests/usr.bin/indent/sac.0.stdout # 20180721: move of libmlx5.so.1 and libibverbs.so.1 OLD_LIBS+=3Dusr/lib/libmlx5.so.1 OLD_LIBS+=3Dusr/lib/libibverbs.so.1 This is sort of like the older part of the file: # 20170322: rename <x> to <x>_test to match the FreeBSD test suite name = scheme OLD_FILES+=3Dusr/tests/usr.bin/col/col OLD_FILES+=3Dusr/tests/usr.bin/diff/diff OLD_FILES+=3Dusr/tests/usr.bin/ident/ident OLD_FILES+=3Dusr/tests/usr.bin/mkimg/mkimg OLD_FILES+=3Dusr/tests/usr.bin/sdiff/sdiff OLD_FILES+=3Dusr/tests/usr.bin/soelim/soelim OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_config OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_etcdir OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_groupadd OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_groupdel OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_groupmod OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_lock OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_useradd OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_userdel OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_usermod OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_usernext =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?446D76C1-4563-43FA-8B25-3A84245385F7>