Date: Fri, 26 Feb 2021 21:48:09 +0000 (UTC) From: Baptiste Daroussin <bapt@FreeBSD.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 2a50a9de8340 - main - terminfo: add terminfo database Message-ID: <44c9cd7b-e032-4613-81be-6214f37d2fbe@FreeBSD.org> In-Reply-To: <E1CBDB73-8A27-49D5-9B1A-7F33CA323528@gmail.com> References: <202102251327.11PDR4eC083842@gitrepo.freebsd.org> <E1CBDB73-8A27-49D5-9B1A-7F33CA323528@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
26 f=C3=A9vr. 2021 22:41:37 Enji Cooper <yaneurabeya@gmail.com>: > >> On Feb 25, 2021, at 5:27 AM, Baptiste Daroussin <bapt@FreeBSD.org> wrote= : >> >> The branch main has been updated by bapt: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D2a50a9de8340f08bd876e9e59= 93332ae14376f80 >> >> commit 2a50a9de8340f08bd876e9e5993332ae14376f80 >> Author:=C2=A0=C2=A0=C2=A0=C2=A0 Baptiste Daroussin <bapt@FreeBSD.org> >> AuthorDate: 2021-02-23 16:17:32 +0000 >> Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Baptiste Daroussin <bapt@FreeBSD.org> >> CommitDate: 2021-02-25 13:25:32 +0000 >> >> =C2=A0=C2=A0 terminfo: add terminfo database >> >> =C2=A0=C2=A0 Tested by:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 manu, jbeich > > Hi Baptiste, > =C2=A0 A question and a comment: > =C2=A0 1. Was this reviewed in Phabricator? > =C2=A0 2. The details on why the terminfo database is being added are a b= it lean too to non-Unix users. It would be nice if the motivation for the c= hange was documented in the commit message. > Thanks! > -Enji No it was not reviewed in phabricator as it does not really bring any code,= but it was discussed on the mailing lists with a heads up on the plan and = the motivation, and all the reaction were in favor of this change. Note thay while it could have been better written this commit is the third = of a serie, where the first one explain a bit more things. Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44c9cd7b-e032-4613-81be-6214f37d2fbe>