Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 22 Aug 2023 01:24:52 +0800
From:      Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        Muhammad Moinur Rahman <bofh@freebsd.org>, ports-committers@freebsd.org,  dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 578591807a5d - main - net/xprobe: Fix build on 14
Message-ID:  <CAMHz58RCCLiZUhQAZ64ukBmiztWgo2RnVAtGs_tbg6VKRy0ocw@mail.gmail.com>
In-Reply-To: <ZOMdfhdTaSrxYmFm@FreeBSD.org>
References:  <202308180657.37I6vKKC082833@gitrepo.freebsd.org> <ZOMdfhdTaSrxYmFm@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help 
--0000000000002e9b0d0603722ade
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 21, 2023 at 4:17=E2=80=AFPM Alexey Dokuchaev <danfe@freebsd.org=
> wrote:

> On Fri, Aug 18, 2023 at 06:57:20AM +0000, Muhammad Moinur Rahman wrote:
> > commit 578591807a5d9bc9dd08130e63d268358b90e100
> >
> >   net/xprobe: Fix build on 14
>
> sunpoet@ had fixed the `register' issue with commit b5c1ed98827f, but
> apparently it was incomplete as it still uses deprecated std::shuffle().
>
> > +.include <bsd.port.options.mk>
> > +
> > +.if ${OPSYS} =3D=3D FreeBSD && ( ${OSVERSION} >=3D 1400091 || ( ${OSVE=
RSION}
> >=3D 1302505 && ${OSVERSION} < 1400000 ))
> > +USES+=3D       llvm:max=3D15
> > +CC=3D  clang${LLVM_VERSION}
> > +CPP=3D clang-cpp${LLVM_VERSION}
> > +CXX=3D clang++${LLVM_VERSION}
> > +.endif
>
> Why not follow e.g. commit 2c1a536ebca3 and patch this properly?
>
> ./danfe
>
>
I've fixed it in 29873d969e02af4315ba32ac52ae43c9d6597040.
Thanks.

--0000000000002e9b0d0603722ade
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Mon, Aug 21, 2023 at 4:17=E2=80=AFPM A=
lexey Dokuchaev &lt;<a href=3D"mailto:danfe@freebsd.org">danfe@freebsd.org<=
/a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex">On Fri, Aug 18, 2023 at 06:57:20AM +0000, Muhamma=
d Moinur Rahman wrote:<br>
&gt; commit 578591807a5d9bc9dd08130e63d268358b90e100<br>
&gt; <br>
&gt;=C2=A0 =C2=A0net/xprobe: Fix build on 14<br>
<br>
sunpoet@ had fixed the `register&#39; issue with commit b5c1ed98827f, but<b=
r>
apparently it was incomplete as it still uses deprecated std::shuffle().<br=
>
<br>
&gt; +.include &lt;<a href=3D"http://bsd.port.options.mk" rel=3D"noreferrer=
" target=3D"_blank">bsd.port.options.mk</a>&gt;<br>
&gt; +<br>
&gt; +.if ${OPSYS} =3D=3D FreeBSD &amp;&amp; ( ${OSVERSION} &gt;=3D 1400091=
 || ( ${OSVERSION} &gt;=3D 1302505 &amp;&amp; ${OSVERSION} &lt; 1400000 ))<=
br>
&gt; +USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0llvm:max=3D15<br>
&gt; +CC=3D=C2=A0 clang${LLVM_VERSION}<br>
&gt; +CPP=3D clang-cpp${LLVM_VERSION}<br>
&gt; +CXX=3D clang++${LLVM_VERSION}<br>
&gt; +.endif<br>
<br>
Why not follow e.g. commit 2c1a536ebca3 and patch this properly?<br>
<br>
./danfe<br>
<br></blockquote><div><br></div><div>I&#39;ve fixed it in=C2=A029873d969e02=
af4315ba32ac52ae43c9d6597040.</div><div>Thanks.=C2=A0</div></div></div>

--0000000000002e9b0d0603722ade--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58RCCLiZUhQAZ64ukBmiztWgo2RnVAtGs_tbg6VKRy0ocw>