Date: Thu, 13 Oct 2016 00:29:04 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Julio Merino <julio@meroh.net> Cc: Ngie Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307190 - head/contrib/netbsd-tests/fs/tmpfs Message-ID: <E1EE7563-8689-4EC6-B311-01C997E40A89@gmail.com> In-Reply-To: <CADyfeQVByd6i5JqHyesodT_a6Fe=k5M5w113d_NEPBvG8xK8OA@mail.gmail.com> References: <201610130702.u9D72sgd007580@repo.freebsd.org> <CADyfeQVByd6i5JqHyesodT_a6Fe=k5M5w113d_NEPBvG8xK8OA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_A0114B37-B420-4886-AA83-5E15D9B6FAB4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 13, 2016, at 00:20, Julio Merino <julio@meroh.net> wrote: >=20 > On Thu, Oct 13, 2016 at 3:02 AM, Ngie Cooper <ngie@freebsd.org> wrote: > Author: ngie > Date: Thu Oct 13 07:02:54 2016 > New Revision: 307190 > URL: https://svnweb.freebsd.org/changeset/base/307190 >=20 > Log: > Skip :uchg on FreeBSD >=20 > Unfortunately removing files with uchg set always succeeds with root = on > FreeBSD. Unfortunately running the test as an unprivileged user = isn't doable > because mounting tmpfs requires root >=20 > PR: 212861 > Sponsored by: Dell EMC Isilon >=20 > Modified: > head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh >=20 > Modified: head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh Thu Oct 13 = 06:56:23 2016 (r307189) > +++ head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh Thu Oct 13 = 07:02:54 2016 (r307190) > @@ -53,6 +53,10 @@ uchg_head() { > atf_set "require.user" "root" > } > uchg_body() { > + # Begin FreeBSD > + atf_skip "this fails on FreeBSD with root - bug 212861" > + # End FreeBSD >=20 > This is a bad way of disabling a test due to a known bug because, when = the bug is resolved, the test won't notice. You should be using the = "expected failures" functionality if possible, and based on the change = description, I think you can do this here easily. Try: >=20 > atf_expect_fail "FreeBSD bug 213861 blah blah" >=20 > right before the line that triggers the test failure. The problem is that this leaves tmpfs mounts lying around, which atf = won=E2=80=99t cleanup. Otherwise, I would totally agree with you. Thanks, -Ngie --Apple-Mail=_A0114B37-B420-4886-AA83-5E15D9B6FAB4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJX/zfBAAoJEPWDqSZpMIYVs64P/0JR4ZNY5nhp66HcTDMWrc+y QK5SSjmLK1AGcguGs54Yt6RWR12zEozYaC6Aq8AojvEAe4oE6wCpUqeFSTChlZ6a NWS2gsZ658+MVyOeyQp2CnryeTWF9/QmUnEi7Z6YtDwLHfOauqzgihwsIkZ2zR47 WCqTuyXX5u/aQqWvmflFc02u6mfkeDDylFbcHEtSJJgoSqpc5VjKrB5WMg8rWw+r FgbK/jRgxmEW5dR+6lVsgVaeSNtTs5nju7QHFEwwwK4FNaAsXb0z4RcSi2ZKwl0R G/a/XhOn6WyuJyBgFWJLh6PRtfv5a2ZphO7NDC4Rwmb3N/ee1hHuJ726GPrKcmdm uniRWHOBgvGPnD78SVyA/z0L4WE7HmqXXxofxz25pNccpzIzAhCQnuEHiPa3FdHg en7r50w6pTEtctlRBWP7vv+7yOdvBtCHoIz2YGJxckF2V/Y6G9rHTeDFYZMLvhim UdXfGHUJfIvRCqMKpjC8OHGPco80mDPwB/prO0uyHdis/u70Wc6I58JD8KDd7t75 VyM8sHtwPEa7i92hWLAsKI/0kiYUd62TiWHi51rjnGyvr84vRAQvRY2VbwHNxfzI 9RbP2rcewIDnwqm2ly9KAqjDEIBa3NekdwRzIMnUOCoJCITO1GYhkGY8MB2dHdB3 fR2x+WzDUl1X3eF6wfFv =lAg2 -----END PGP SIGNATURE----- --Apple-Mail=_A0114B37-B420-4886-AA83-5E15D9B6FAB4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1EE7563-8689-4EC6-B311-01C997E40A89>