Date: Fri, 12 Jul 2013 23:27:12 +0300 From: Mikolaj Golub <trociny@FreeBSD.org> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, Marko Zec <zec@fer.hr> Subject: Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt Message-ID: <20130712202710.GB2757@gmail.com> In-Reply-To: <CAG=rPVcxvWq-MoXADiv%2BgLY-d3hhv1GTMO1R14bhLRm9UB9DqA@mail.gmail.com> References: <201307120803.r6C83ACp016523@svn.freebsd.org> <CAJ-Vmonrmgr3HJRzQtVmWp=8SkpSeWNVeBZgOnSnE72NNp=3DQ@mail.gmail.com> <CAG=rPVcxvWq-MoXADiv%2BgLY-d3hhv1GTMO1R14bhLRm9UB9DqA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 12, 2013 at 11:39:34AM -0700, Craig Rodrigues wrote: > I like your patch. It may be worth having one more Netgraph person review > it and give a sanity check, but > I think we should commit your patch ASAP. > I am new to VNET, but I am wondering if in your patch we can KASSERT if > node->vnet is NULL. That would make > things easier to debug. > > The part of my patch which which does CURVNET_SET is still necessary upon > attach in Bluetooth. > However, with your patch, we can get rid of the part of my patch which does > CURVNET_SET upon Bluetooth detach. Some time ago there was a long discussion about VIMAGE issue with hotplugabble network devices: http://lists.freebsd.org/pipermail/freebsd-hackers/2012-October/040784.html (I wander why Adrian did not mention it as he was deeply involved) Then Marko came up with a patch that mihght fix the issue in a more generic way: http://lists.freebsd.org/pipermail/freebsd-hackers/2012-November/041120.html Unfortunately it was not tested. I think it would be very interesting to try it with hotplugabble devices. (I don't have any so can't test). -- Mikolaj Golub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130712202710.GB2757>