Date: Sat, 13 Mar 2004 10:57:19 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: cvs-src@freebsd.org Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/share/mk bsd.cpu.mk bsd.dep.mk bsd.lib.mk bsd.sys.mk src/sys/conf files kern.mk kern.pre.mk kmod.mk src/sys/dev/aic7xxx/aicasm Makefile Message-ID: <20040313105719.5e4e8765@Magellan.Leidinger.net> In-Reply-To: <20040312215649.GA4588@ip.net.ua> References: <200403122136.i2CLaCm9096276@repoman.freebsd.org> <20040312215649.GA4588@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 12 Mar 2004 23:56:49 +0200
Ruslan Ermilov <ru@freebsd.org> wrote:
> > Index: src/share/mk/bsd.lib.mk
> > diff -u src/share/mk/bsd.lib.mk:1.156 src/share/mk/bsd.lib.mk:1.157
> > --- src/share/mk/bsd.lib.mk:1.156 Tue Jan 27 15:22:15 2004
> > +++ src/share/mk/bsd.lib.mk Fri Mar 12 13:36:12 2004
> [...]
> > +.c.o:
> > + ${CC} ${CFLAGS} -c ${.IMPSRC} -o ${.TARGET}
> > +
> >
> Please revert the addition of this, it's bogus and duplicated
> what's already in sys.mk.
Ooops... sorry. I think this bogus change crept in at the time you moved
this part to sys.mk (at least I think you did something like this, and I
forgot to review your change entirely).
> > @@ -157,7 +166,7 @@
> > ${LINT} ${LINTLIBFLAGS} ${CFLAGS:M-[DIU]*} ${.ALLSRC}
> > .endif
> >
> > -.endif !defined(INTERNALLIB)
> > +.endif #!defined(INTERNALLIB)
> >
> Please revert this.
Why? .endif doesn't take an argument and it serves as a comment. So why
not make it explicit? I would agree with adding a space after the
comment sign, but I don't understand why it should be reverted.
Thanks for the review,
Alexander.
--
I will be available to get hired in April 2004.
http://www.Leidinger.net Alexander @ Leidinger.net
GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040313105719.5e4e8765>