Date: Tue, 19 Sep 2006 14:27:29 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <200609191427.31736.jkim@FreeBSD.org> In-Reply-To: <200609191232.54332.jhb@freebsd.org> References: <200609182218.k8IMIMUT059300@repoman.freebsd.org> <200609191232.54332.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 19 September 2006 12:32 pm, John Baldwin wrote: > On Monday 18 September 2006 18:18, Jung-uk Kim wrote: > > jkim 2006-09-18 22:18:22 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bge if_bge.c > > Log: > > Do not strip VLAN tag in promiscuous mode. > > Why did you change this? Does bge not work correctly with both > enabled? It does work. Only problem is that VLAN tags are stripped before reaching bpf. Thus, applications like tcpdump and wireshark don't see the VLAN tags. http://docs.freebsd.org/cgi/mid.cgi?9256D57F598E6C41B288AA7DB94F29C902DFB963 http://docs.freebsd.org/cgi/mid.cgi?200410121035.59905.jkim As I said earlier, it is just a stopgap until we teach bpf to insert VLAN tags back. In fact, my intention was to MFC this before 6.2 release and to fix -CURRENT when we have correct implementation because I don't think we can add the 'feature' in time. If every one dislikes this, I have no problem backing it out, of course. Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200609191427.31736.jkim>