Date: Thu, 7 May 2020 19:04:03 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Li-Wen Hsu <lwhsu@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r360722 - head/sys/dev/virtio/mmio Message-ID: <68E0E25D-759A-4D4C-895B-0AB98A3493C9@freebsd.org> In-Reply-To: <20200507172530.GA61260@freefall.freebsd.org> References: <202005062328.046NSp8x079151@repo.freebsd.org> <20200507172530.GA61260@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7 May 2020, at 18:25, Li-Wen Hsu <lwhsu@freebsd.org> wrote: > On Wed, May 06, 2020 at 23:28:51 +0000, Jessica Clarke wrote: >> Author: jrtc27 >> Date: Wed May 6 23:28:51 2020 >> New Revision: 360722 >> URL: https://svnweb.freebsd.org/changeset/base/360722 >>=20 >> Log: >> virtio_mmio: Support non-transitional version 2 devices >>=20 >> The non-legacy virtio MMIO specification drops the use of PFNs and >> replaces them with physical addresses. Whilst many implementations = are >> so-called transitional devices, also implementing the legacy >> specification, TinyEMU[1] does not. Device-specific configuration >> registers have also changed to being little-endian, and must be = accessed >> using a single aligned access for registers up to 32 bits, and two >> 32-bit aligned accesses for 64-bit registers. >>=20 >> [1] https://bellard.org/tinyemu/ >>=20 >> Reviewed by: br, brooks (mentor) >> Approved by: br, brooks (mentor) >> Differential Revision: https://reviews.freebsd.org/D24681 >>=20 >> Modified: >> head/sys/dev/virtio/mmio/virtio_mmio.c >> head/sys/dev/virtio/mmio/virtio_mmio.h >=20 > Hi Jessica, >=20 > It looks this commit breaks armv6 and armv7 builds: >=20 >=20 > --- virtio_mmio.o --- > /usr/src/sys/dev/virtio/mmio/virtio_mmio.c:442:13: error: shift count = >=3D width of type [-Werror,-Wshift-count-overflow] > paddr >> 32); > ^ ~~ > /usr/src/sys/dev/virtio/mmio/virtio_mmio.c:127:44: note: expanded from = macro 'vtmmio_write_config_4' > VIRTIO_MMIO_PREWRITE(sc->platform, (o), (v)); \ > ^ > ... >=20 > https://ci.freebsd.org/job/FreeBSD-head-armv6-build/9109/console > https://ci.freebsd.org/job/FreeBSD-head-armv7-build/9035/console Thanks, yes, of course. This should be fixed as of r360789. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?68E0E25D-759A-4D4C-895B-0AB98A3493C9>