Date: Mon, 15 Sep 2014 14:50:02 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Hans Petter Selasky <hselasky@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r271504 - in head/sys: dev/oce dev/vmware/vmxnet3 dev/xen/netfront net netinet ofed/drivers/net/mlx4 Message-ID: <20140915105002.GQ60617@FreeBSD.org> In-Reply-To: <201409130826.s8D8Q9Wx078339@svn.freebsd.org> References: <201409130826.s8D8Q9Wx078339@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hans,
I second on Adrians suggestions.
Also, this chunk:
H> Modified: head/sys/netinet/tcp_output.c
H> ==============================================================================
H> --- head/sys/netinet/tcp_output.c Sat Sep 13 07:45:03 2014 (r271503)
H> +++ head/sys/netinet/tcp_output.c Sat Sep 13 08:26:09 2014 (r271504)
H> @@ -52,6 +52,7 @@ __FBSDID("$FreeBSD$");
H> #include <sys/sysctl.h>
H>
H> #include <net/if.h>
H> +#include <net/if_var.h>
H> #include <net/route.h>
H> #include <net/vnet.h>
Is it possible to avoid this inclusion? I'd even suggest to push
all TSO (or all TCP hardware assistance stuff) into a separate
header, that is shared between TCP and drivers, w/o polluting
TCP with all ifnet knowledge.
--
Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140915105002.GQ60617>