Date: Tue, 5 Aug 2003 14:28:15 +0200 From: Johan Karlsson <johan@FreeBSD.org> To: Diomidis Spinellis <dds@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sym sym_fw.h Message-ID: <20030805122815.GA17099@numeri.campus.luth.se> In-Reply-To: <200308050722.h757MCxl098780@repoman.freebsd.org> References: <200308050722.h757MCxl098780@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 05, 2003 at 00:22 (-0700) +0000, Diomidis Spinellis wrote:
> dds 2003/08/05 00:22:12 PDT
>
> FreeBSD src repository
>
> Modified files:
> sys/dev/sym sym_fw.h
> Log:
> Remove extraneous semicolons. They are already provided by
> the macro definition, and cause the generation of syntactically
> incorrect code that gcc happens to accept.
This is backwards.
>From style(9):
Any final statement-ter-
minating semicolon should be supplied by the macro invocation rather than
the macro, to make parsing easier for pretty-printers and editors.
Please consider reverting this and change the macros in the file to not
supply the terminating semicolon.
/Johan K
>
> Reviewed by: schweikh (mentor)
> MFC after: 4 weeks
>
> Revision Changes Path
> 1.4 +4 -4 src/sys/dev/sym/sym_fw.h
--
Johan Karlsson mailto:johan@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030805122815.GA17099>