Date: Mon, 15 Oct 2001 13:40:10 -0700 (PDT) From: "Crist J. Clark" <cristjc@earthlink.net> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/31199: tunefs error is incorrect when enabling softupdates Message-ID: <200110152040.f9FKeAp48036@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/31199; it has been noted by GNATS.
From: "Crist J. Clark" <cristjc@earthlink.net>
To: Bruce Evans <bde@zeta.org.au>
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: bin/31199: tunefs error is incorrect when enabling softupdates
Date: Mon, 15 Oct 2001 13:38:34 -0700
On Tue, Oct 16, 2001 at 01:22:37AM +1000, Bruce Evans wrote:
> On Mon, 15 Oct 2001, Crist J. Clark wrote:
[snip]
> > The messages should reflect that it is collecting the values
> > before it actually tries to write them. Something more like,
> >
> > $ tunefs -n enable /dev/ad0s1a
> > tunefs: setting soft updates...
> > tunefs: cannot open /dev/ad0s1a: Permission denied
>
> The "setting" message used to be "soft updates set". I changed this to
> "soft updates changes from disabled to enabled" (and similarly for
> "soft updates cleared" so that the wording is similar for all the messages.
OK. Probably better. This hasn't been committed yet, though?
> > And in a successful run (since tunefs(8) is already chatty on
> > success),
> >
> > $ tunefs -n enable /dev/ad0s1a
> > tunefs: setting soft updates...
> > tunefs: changes on /dev/ad0s1 done
>
> The "changes done" message is silly if tunefs has only printed "remains
> unchanged" messages.
But then again, even if there are no changes, tunefs(8)
unconditionally writes the "modified" data.
--
Crist J. Clark | cjclark@alum.mit.edu
| cjclark@jhu.edu
http://people.freebsd.org/~cjc/ | cjc@freebsd.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200110152040.f9FKeAp48036>