Date: Mon, 23 Jan 2012 15:13:07 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Hiroki Sato <hrs@freebsd.org>, eadler@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs Message-ID: <4F1D6AF3.2030303@FreeBSD.org> In-Reply-To: <20120123123132.GM31224@deviant.kiev.zoral.com.ua> References: <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> <CAF6rxg=VWzUcDuk_oN_wepJPejg8JnGBKm5oLXB7Y8JCW52t3w@mail.gmail.com> <20120123.132840.618925004528110765.hrs@allbsd.org> <4F1D51A0.6040405@FreeBSD.org> <20120123123132.GM31224@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-01-23 13:31, Kostik Belousov wrote:
> On Mon, Jan 23, 2012 at 01:25:04PM +0100, Dimitry Andric wrote:
...
> There is a typo in the second or condition, should it be gcc46 both times ?
Ah, sorry, that was a copy/paste error.
> Anyway, the reason to answer this message is two ask the for seemingly
> unreasonable approach of matching compiler type/version based on the
> driver name. This completely precludes anybody from using gcc installed
> not from the ports tree.
Yes, that is indeed the big problem with this approach. Although I
think the number of people that hand-build gcc, and not use the ports
will be rather low. :)
> Could the tests performed based on the driver version information
> instead of name ?
Probably, but then you would have to run "${CC} --version" plus some
sed/awk'ing from bsd.sys.mk. That could add quite some extra forking
during buildworld.
It may be easier to add a COMPILER_FLAVOR (just an example name) setting
in make.conf, which can be set independently of CC, CXX and so on, to
tell which specific variant of gcc, clang etc you want to use.
The processing of that setting could happen in either sys.mk or
bsd.sys.mk, or be separated out to a bsd.compiler.mk, for instance.
In each .mk file or Makefile that needs it, the ${CC:T:M:foo} == "foo"
comparisons can then be replaced with ${COMPILER_FLAVOR} == "foo".
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F1D6AF3.2030303>