Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 May 2010 18:30:08 GMT
From:      dfilter@FreeBSD.ORG (dfilter service)
To:        freebsd-net@FreeBSD.org
Subject:   Re: kern/146759: commit references a PR
Message-ID:  <201005201830.o4KIU8TC005260@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/146759; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/146759: commit references a PR
Date: Thu, 20 May 2010 18:22:57 +0000 (UTC)

 Author: np
 Date: Thu May 20 18:22:45 2010
 New Revision: 208356
 URL: http://svn.freebsd.org/changeset/base/208356
 
 Log:
   Remove invalid assertion.
   
   Holding the adapter lock while changing the LRO settings is sufficient.
   
   PR:		kern/146759
   MFC after:	3 days
 
 Modified:
   head/sys/dev/cxgb/cxgb_main.c
 
 Modified: head/sys/dev/cxgb/cxgb_main.c
 ==============================================================================
 --- head/sys/dev/cxgb/cxgb_main.c	Thu May 20 17:30:55 2010	(r208355)
 +++ head/sys/dev/cxgb/cxgb_main.c	Thu May 20 18:22:45 2010	(r208356)
 @@ -1979,7 +1979,6 @@ cxgb_set_lro(struct port_info *p, int en
  	struct adapter *adp = p->adapter;
  	struct sge_qset *q;
  
 -	PORT_LOCK_ASSERT_OWNED(p);
  	for (i = 0; i < p->nqsets; i++) {
  		q = &adp->sge.qs[p->first_qset + i];
  		q->lro.enabled = (enabled != 0);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201005201830.o4KIU8TC005260>