Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Jul 2009 22:21:46 +0100
From:      Lawrence Stewart <lstewart@freebsd.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, np@freebsd.org
Subject:   Re: svn commit: r195654 - in head: . sys/dev/cxgb/ulp/tom sys/netinet sys/sys
Message-ID:  <4A5BA56A.8000208@freebsd.org>
In-Reply-To: <20090713203416.GA2976@hub.freebsd.org>
References:  <200907131151.n6DBp35J024156@svn.freebsd.org> <20090713203416.GA2976@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Navdeep Parhar wrote:
[snip]
> 
> Hello Lawrence,
> 
> 'to' should be renamed to 'toeo' in syncache_expand_establish_req() before the
> changes you made to cxgb_cpl_io.c will even compile.
> 
> -	struct toeopt to;
> +	struct toeopt toeo;

Oh dear, mea culpa.

> 
> Unfortunately, cxgb's TOM is commented out of the build system (ever since
> ARPv2) and so buildkernel won't catch stuff like this.  I have a tree that
> builds TOM with the latest head but it won't be ready+tested in time for 8.0.

That would explain why I missed this :(

Will get it fixed right away.

Cheers,
Lawrence



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A5BA56A.8000208>