Date: Fri, 11 Mar 2016 10:50:08 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Ed Maste <emaste@freebsd.org> Cc: "src-committers\@freebsd.org" <src-committers@freebsd.org>, "svn-src-all\@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head\@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r296633 - in head: crypto/openssh crypto/openssh/contrib crypto/openssh/contrib/redhat crypto/openssh/contrib/suse crypto/openssh/openbsd-compat crypto/openssh/regress crypto/openssh/re... Message-ID: <867fh9cpin.fsf@desk.des.no> In-Reply-To: <CAPyFy2AvpMC_omq8%2BDeSGuGC=v4tiV=GmDeosfkORcnDVPeKGg@mail.gmail.com> (Ed Maste's message of "Fri, 11 Mar 2016 03:05:32 %2B0000") References: <201603110015.u2B0FT5v065136@repo.freebsd.org> <CAPyFy2AvpMC_omq8%2BDeSGuGC=v4tiV=GmDeosfkORcnDVPeKGg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Ed Maste <emaste@freebsd.org> writes:
> It looks like this broke mips:
>
> In file included from
> /scratch/tmp/emaste/freebsd/lib/libpam/modules/pam_ssh/../../../../crypto/openssh/key.h:29,
> from
> /scratch/tmp/emaste/freebsd/lib/libpam/modules/pam_ssh/pam_ssh.c:60:
> /scratch/tmp/emaste/freebsd/lib/libpam/modules/pam_ssh/../../../../crypto/openssh/sshkey.h:145:
> warning: '__bounded__' attribute directive ignored
Please try the attached patch. I don't know if it fixes the issue, but
it's a good idea either way. I'm trying to find out why gcc complains
about this specific instance of __bounded__ but not about any of the 88
others in OpenSSH; the only lead I have so far is that pam_ssh uses a
different WARNS level.
DES
--
Dag-Erling Smørgrav - des@des.no
[-- Attachment #2 --]
Index: lib/libpam/modules/pam_ssh/Makefile
===================================================================
--- lib/libpam/modules/pam_ssh/Makefile (revision 296634)
+++ lib/libpam/modules/pam_ssh/Makefile (working copy)
@@ -7,7 +7,6 @@
MAN= pam_ssh.8
SRCS= pam_ssh.c
-WARNS?= 3
CFLAGS+= -I${SSHDIR} -include ssh_namespace.h
SRCS+= ssh_namespace.h
Index: lib/libpam/modules/pam_ssh/pam_ssh.c
===================================================================
--- lib/libpam/modules/pam_ssh/pam_ssh.c (revision 296634)
+++ lib/libpam/modules/pam_ssh/pam_ssh.c (working copy)
@@ -84,7 +84,9 @@
};
static const char *pam_ssh_agent = "/usr/bin/ssh-agent";
-static char *const pam_ssh_agent_argv[] = { "ssh_agent", "-s", NULL };
+static char str_ssh_agent[] = "ssh-agent";
+static char str_dash_s[] = "-s";
+static char *const pam_ssh_agent_argv[] = { str_ssh_agent, str_dash_s, NULL };
static char *const pam_ssh_agent_envp[] = { NULL };
/*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?867fh9cpin.fsf>