Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Apr 2026 16:29:08 +0000
From:      Enji Cooper <ngie@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 41924423f7eb - stable/14 - asmc: use `ASMC_FAN_FUNCS2` with the Macmini4,1
Message-ID:  <69ecebd4.44b70.4670c26c@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/14 has been updated by ngie:

URL: https://cgit.FreeBSD.org/src/commit/?id=41924423f7eb6e84449a37d5273598e665cd138f

commit 41924423f7eb6e84449a37d5273598e665cd138f
Author:     Enji Cooper <ngie@FreeBSD.org>
AuthorDate: 2026-02-20 05:43:37 +0000
Commit:     Enji Cooper <ngie@FreeBSD.org>
CommitDate: 2026-04-25 16:29:03 +0000

    asmc: use `ASMC_FAN_FUNCS2` with the Macmini4,1
    
    The Macmini4,1 model does not have "fansafespeed" support. This issue
    typically manifests with messages like so:
    
    ```
    asmc0: asmc_key_read for key F0Sf failed 10 times, giving up
    ```
    
    Swap out `ASMC_FAN_FUNCS` with `ASMC_FAN_FUNCS2` to explicitly drop
    "fansafespeed" checks in the driver for the model as it doesn't support
    that hardware feature.
    
    MFC after:      1 week
    Reported by:    @probonopd
    Closes:         https://github.com/helloSystem/ISO/issues/357
    
    (cherry picked from commit 7b862cf8a252d80ab1fb90fa5371fd8462c7c16f)
---
 sys/dev/asmc/asmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/asmc/asmc.c b/sys/dev/asmc/asmc.c
index 066b9c80de23..5620c8c42d89 100644
--- a/sys/dev/asmc/asmc.c
+++ b/sys/dev/asmc/asmc.c
@@ -347,7 +347,7 @@ static const struct asmc_model asmc_models[] = {
 	{
 	  "Macmini4,1", "Apple SMC Mac mini 4,1 (Mid-2010)",
 	  ASMC_SMS_FUNCS_DISABLED,
-	  ASMC_FAN_FUNCS,
+	  ASMC_FAN_FUNCS2,
 	  ASMC_LIGHT_FUNCS_DISABLED,
 	  ASMC_MM41_TEMPS, ASMC_MM41_TEMPNAMES, ASMC_MM41_TEMPDESCS
 	},


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69ecebd4.44b70.4670c26c>