Date: Sat, 2 Nov 1996 16:30:01 -0500 (EST) From: gpalmer@freebsd.org To: FreeBSD-gnats-submit@freebsd.org Subject: bin/1945: Out of date code/comments in dd Message-ID: <199611022130.QAA05307@mutara.noc.webspan.net> Resent-Message-ID: <199611022140.NAA26180@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 1945 >Category: bin >Synopsis: Out of date code/comments in dd >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Nov 2 13:40:01 PST 1996 >Last-Modified: >Originator: Gary Palmer >Organization: Webspan Inc >Release: FreeBSD 2.2-current i386 >Environment: cvs-cur 2654 >Description: Code/comments in bin/dd/args.c seem to think that lseek takes an int for an argument, but it takes an `off_t' argument. There is even (as Bruce would say) a bogus cast in the code to quiet the compiler. >How-To-Repeat: Look at args.c around line 167, and dd.c around lines 230 and 278 >Fix: Bring the code into the modern age and use off_t's like it should. >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199611022130.QAA05307>