Date: Mon, 13 Jul 2009 17:23:03 -0600 From: Scott Long <scottl@samsco.org> To: Marcel Moolenaar <xcllnt@mac.com> Cc: svn-src-head@FreeBSD.org, Alexander Motin <mav@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r195653 - head/sys/cam/ata Message-ID: <4A5BC1D7.8080300@samsco.org> In-Reply-To: <4C53B490-A1B0-4841-81B2-A8F06D353349@mac.com> References: <200907130612.n6D6CLMP014560@svn.freebsd.org> <4C53B490-A1B0-4841-81B2-A8F06D353349@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar wrote: > > On Jul 12, 2009, at 11:12 PM, Alexander Motin wrote: > >> Author: mav >> Date: Mon Jul 13 06:12:21 2009 >> New Revision: 195653 >> URL: http://svn.freebsd.org/changeset/base/195653 >> >> Log: >> Rename ATA probe driver to "aprobe" to resolve name conflict with SCSI >> and fix loading cam as module. > > While this may avoid a conflict, it's hardly a good name that > has a low chance of conflicting with something else. > > Please consider (in due time) to improve the descriptiveness. > Something like "ata_cam_probe" doesn't look like a bad choice > to me... > > Just food for thought... > Is there nothing else in this entire piece of work that can be commented on besides the goddamned names? Holy hell. The bikeshed, it's not just a cliche, it's a f@@@ing way of life around here. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A5BC1D7.8080300>